third_party/WebKit/Source/web/tests/WebViewTest.cpp - Issue 2307003002: Move collectGarbage* methods to ThreadState

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/web/tests/WebViewTest.cpp

Issue 2307003002: Move collectGarbage* methods to ThreadState (Closed)

Patch Set: fix Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/web/tests/WebViewTest.cpp

diff --git a/third_party/WebKit/Source/web/tests/WebViewTest.cpp b/third_party/WebKit/Source/web/tests/WebViewTest.cpp

index ebda5112b4aac7dfd91c56a86dad1a6eba7d627b..47dbdb25f888538dfee33503184b7c65013ae9aa 100644

--- a/third_party/WebKit/Source/web/tests/WebViewTest.cpp

+++ b/third_party/WebKit/Source/web/tests/WebViewTest.cpp

@@ -2709,7 +2709,7 @@ TEST_F(WebViewTest, DeleteElementWithRegisteredHandler)

// checking below. We do a precise GC (collectAllGarbage does not scan the stack)

// to ensure the div element dies. This is also why the Document is in a Persistent

// since we want that to stay around.

- ThreadHeap::collectAllGarbage();

+ ThreadState::current()-> collectAllGarbage();

EXPECT_FALSE(registry.hasEventHandlers(EventHandlerRegistry::ScrollEvent));

}