third_party/WebKit/Source/core/animation/AnimationStackTest.cpp - Issue 2307003002: Move collectGarbage* methods to ThreadState

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/animation/AnimationStackTest.cpp

Issue 2307003002: Move collectGarbage* methods to ThreadState (Closed)

Patch Set: fix Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/bindings/core/v8/V8GCController.cpp ('K') | « third_party/WebKit/Source/core/animation/AnimationInputHelpersTest.cpp ('k') | third_party/WebKit/Source/core/animation/AnimationTest.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/animation/AnimationStackTest.cpp

diff --git a/third_party/WebKit/Source/core/animation/AnimationStackTest.cpp b/third_party/WebKit/Source/core/animation/AnimationStackTest.cpp

index ab681c87312596abd083e9d3e197d4d04d865e72..58cd4cb461bd9ccfda72e9708851fb2200f85704 100644

--- a/third_party/WebKit/Source/core/animation/AnimationStackTest.cpp

+++ b/third_party/WebKit/Source/core/animation/AnimationStackTest.cpp

@@ -143,28 +143,28 @@ TEST_F(AnimationAnimationStackTest, ForwardsFillDiscarding)

ActiveInterpolationsMap interpolations;

updateTimeline(11);

- ThreadHeap::collectAllGarbage();

+ ThreadState::current()-> collectAllGarbage();

interpolations = AnimationStack::activeInterpolations(&element->elementAnimations()->animationStack(), nullptr, nullptr, KeyframeEffect::DefaultPriority);

EXPECT_EQ(1u, interpolations.size());

EXPECT_TRUE(interpolationValue(interpolations, CSSPropertyFontSize)->equals(AnimatableDouble::create(3).get()));

EXPECT_EQ(3u, sampledEffectCount());

updateTimeline(13);

- ThreadHeap::collectAllGarbage();

+ ThreadState::current()-> collectAllGarbage();

interpolations = AnimationStack::activeInterpolations(&element->elementAnimations()->animationStack(), nullptr, nullptr, KeyframeEffect::DefaultPriority);

EXPECT_EQ(1u, interpolations.size());

EXPECT_TRUE(interpolationValue(interpolations, CSSPropertyFontSize)->equals(AnimatableDouble::create(3).get()));

EXPECT_EQ(3u, sampledEffectCount());

updateTimeline(15);

- ThreadHeap::collectAllGarbage();

+ ThreadState::current()-> collectAllGarbage();

interpolations = AnimationStack::activeInterpolations(&element->elementAnimations()->animationStack(), nullptr, nullptr, KeyframeEffect::DefaultPriority);

EXPECT_EQ(1u, interpolations.size());

EXPECT_TRUE(interpolationValue(interpolations, CSSPropertyFontSize)->equals(AnimatableDouble::create(3).get()));

EXPECT_EQ(2u, sampledEffectCount());

updateTimeline(17);

- ThreadHeap::collectAllGarbage();

+ ThreadState::current()-> collectAllGarbage();

interpolations = AnimationStack::activeInterpolations(&element->elementAnimations()->animationStack(), nullptr, nullptr, KeyframeEffect::DefaultPriority);

EXPECT_EQ(1u, interpolations.size());

EXPECT_TRUE(interpolationValue(interpolations, CSSPropertyFontSize)->equals(AnimatableDouble::create(3).get()));