Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issue 2306933002: Remove wow_helper. (Closed)

Created:
4 years, 3 months ago by grt (UTC plus 2)
Modified:
4 years, 3 months ago
CC:
chromium-reviews, grt+watch_chromium.org, pennymac+watch_chromium.org, rickyz+watch_chromium.org, wfh+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove wow_helper. Use of the helper (removed in r382419) was only needed on XP and Vista. Also removes a VERY old reference to chrome_frame_mini_installer.exe in checkbins.py. BUG=none R=wfh@chromium.org TBR=thestig@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win10_chromium_x64_rel_ng Committed: https://crrev.com/1812d0d777dbe2162e88f6a0a205c8b483008626 Cr-Commit-Position: refs/heads/master@{#416336}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -893 lines) Patch
M chrome/chrome.isolate View 1 chunk +0 lines, -7 lines 0 comments Download
M chrome/installer/mini_installer/chrome.release View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/installer/setup/install_worker.cc View 1 chunk +0 lines, -14 lines 0 comments Download
M chrome/installer/setup/setup_constants.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/installer/setup/setup_constants.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/tools/build/win/FILES.cfg View 1 chunk +0 lines, -5 lines 0 comments Download
M sandbox/win/BUILD.gn View 1 chunk +0 lines, -19 lines 0 comments Download
M sandbox/win/sandbox_win.gypi View 1 chunk +0 lines, -13 lines 0 comments Download
M sandbox/win/src/sandbox.vcproj View 2 chunks +0 lines, -10 lines 0 comments Download
D sandbox/win/wow_helper.sln View 1 chunk +0 lines, -19 lines 0 comments Download
D sandbox/win/wow_helper/service64_resolver.h View 1 chunk +0 lines, -75 lines 0 comments Download
D sandbox/win/wow_helper/service64_resolver.cc View 1 chunk +0 lines, -347 lines 0 comments Download
D sandbox/win/wow_helper/target_code.h View 1 chunk +0 lines, -41 lines 0 comments Download
D sandbox/win/wow_helper/target_code.cc View 1 chunk +0 lines, -34 lines 0 comments Download
D sandbox/win/wow_helper/wow_helper.cc View 1 chunk +0 lines, -87 lines 0 comments Download
D sandbox/win/wow_helper/wow_helper.exe View Binary file 0 comments Download
D sandbox/win/wow_helper/wow_helper.pdb View Binary file 0 comments Download
D sandbox/win/wow_helper/wow_helper.vcproj View 1 chunk +0 lines, -215 lines 0 comments Download
M tools/checkbins/checkbins.py View 1 chunk +2 lines, -4 lines 0 comments Download

Messages

Total messages: 23 (14 generated)
grt (UTC plus 2)
PTAL
4 years, 3 months ago (2016-09-02 08:58:03 UTC) #6
Will Harris
wow I thought this has already gone. Thanks for being the helper to delete this. ...
4 years, 3 months ago (2016-09-02 17:40:13 UTC) #10
grt (UTC plus 2)
+scottmg for checkbins OWNERS review +TBR thestig for .isolate change (which, as I understand it, ...
4 years, 3 months ago (2016-09-02 20:24:58 UTC) #14
scottmg
Exciting, I didn't know that was XP/Vista only. BUG=579196 I guess.
4 years, 3 months ago (2016-09-02 20:28:38 UTC) #15
scottmg
And checkbins lgtm.
4 years, 3 months ago (2016-09-02 20:29:10 UTC) #16
Lei Zhang
lgtm
4 years, 3 months ago (2016-09-02 20:30:32 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2306933002/20001
4 years, 3 months ago (2016-09-02 20:33:14 UTC) #19
commit-bot: I haz the power
Committed patchset #1 (id:20001)
4 years, 3 months ago (2016-09-02 20:38:04 UTC) #21
commit-bot: I haz the power
4 years, 3 months ago (2016-09-02 20:39:42 UTC) #23
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1812d0d777dbe2162e88f6a0a205c8b483008626
Cr-Commit-Position: refs/heads/master@{#416336}

Powered by Google App Engine
This is Rietveld 408576698