Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(376)

Issue 230693003: Handlify and convert string.length to new API-style accessor. (Closed)

Created:
6 years, 8 months ago by ulan
Modified:
6 years, 8 months ago
Reviewers:
dcarney, Yang
CC:
v8-dev
Visibility:
Public.

Description

Handlify and convert string.length to new API-style accessor. BUG= R=dcarney@chromium.org, yangguo@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=20652

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+90 lines, -19 lines) Patch
M src/accessors.h View 4 chunks +22 lines, -2 lines 0 comments Download
M src/accessors.cc View 2 chunks +54 lines, -14 lines 0 comments Download
M src/bootstrapper.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/serialize.cc View 1 chunk +12 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
ulan
Please take a look. If this looks good, I will convert the remaining accessors.
6 years, 8 months ago (2014-04-09 14:23:59 UTC) #1
Yang
On 2014/04/09 14:23:59, ulan wrote: > Please take a look. If this looks good, I ...
6 years, 8 months ago (2014-04-09 14:28:13 UTC) #2
dcarney
finally! lgtm
6 years, 8 months ago (2014-04-09 14:29:44 UTC) #3
ulan
6 years, 8 months ago (2014-04-10 12:00:43 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 manually as r20652 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698