Issue 230693003: Handlify and convert string.length to new API-style accessor.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 230693003: Handlify and convert string.length to new API-style accessor. (Closed)

Created:
6 years, 8 months ago by ulan

Modified:
6 years, 8 months ago

Reviewers:
dcarney, Yang

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Created: 6 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+90 lines, -19 lines)			Patch
M	src/accessors.h	View	4 chunks	+22 lines, -2 lines	0 comments	Download
M	src/accessors.cc	View	2 chunks	+54 lines, -14 lines	0 comments	Download
M	src/bootstrapper.cc	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	src/serialize.cc	View	1 chunk	+12 lines, -1 line	0 comments	Download

Total messages: 4 (0 generated)

ulan

Please take a look. If this looks good, I will convert the remaining accessors.

6 years, 8 months ago (2014-04-09 14:23:59 UTC) #1

Yang

On 2014/04/09 14:23:59, ulan wrote: > Please take a look. If this looks good, I ...

6 years, 8 months ago (2014-04-09 14:28:13 UTC) #2

ulan

6 years, 8 months ago (2014-04-10 12:00:43 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 manually as r20652 (presubmit successful).