Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(142)

Issue 2306873002: Make slotchange events bubble (Closed)

Created:
4 years, 3 months ago by hayato
Modified:
4 years, 3 months ago
Reviewers:
tkent, kochi
CC:
blink-reviews, blink-reviews-html_chromium.org, chromium-reviews, dglazkov+blink
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make slotchange events bubble The spec is: https://dom.spec.whatwg.org/#notify-mutation-observers ; open this link, and find-in-page by "slotchange". This CL is a bug fix. The current behavior is unintentional. BUG=641140 Committed: https://crrev.com/db300b7b07375236467cfcc9aad82b8f8affa36b Cr-Commit-Position: refs/heads/master@{#416197}

Patch Set 1 #

Patch Set 2 : fix #

Total comments: 4

Patch Set 3 : fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -2 lines) Patch
M third_party/WebKit/LayoutTests/shadow-dom/slotchange.html View 1 2 2 chunks +16 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/HTMLSlotElement.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 20 (11 generated)
hayato
fix
4 years, 3 months ago (2016-09-02 02:44:41 UTC) #3
hayato
PTAL
4 years, 3 months ago (2016-09-02 02:45:11 UTC) #7
tkent
lgtm
4 years, 3 months ago (2016-09-02 02:53:15 UTC) #8
kochi
lgtm https://codereview.chromium.org/2306873002/diff/20001/third_party/WebKit/LayoutTests/shadow-dom/slotchange.html File third_party/WebKit/LayoutTests/shadow-dom/slotchange.html (right): https://codereview.chromium.org/2306873002/diff/20001/third_party/WebKit/LayoutTests/shadow-dom/slotchange.html#newcode33 third_party/WebKit/LayoutTests/shadow-dom/slotchange.html:33: n.shadowroot.addEventListener('slotchange', test.step_func((e) => { nit: you can use ...
4 years, 3 months ago (2016-09-02 02:57:06 UTC) #9
hayato
fix
4 years, 3 months ago (2016-09-02 04:07:33 UTC) #10
hayato
https://codereview.chromium.org/2306873002/diff/20001/third_party/WebKit/LayoutTests/shadow-dom/slotchange.html File third_party/WebKit/LayoutTests/shadow-dom/slotchange.html (right): https://codereview.chromium.org/2306873002/diff/20001/third_party/WebKit/LayoutTests/shadow-dom/slotchange.html#newcode33 third_party/WebKit/LayoutTests/shadow-dom/slotchange.html:33: n.shadowroot.addEventListener('slotchange', test.step_func((e) => { Done. https://codereview.chromium.org/2306873002/diff/20001/third_party/WebKit/LayoutTests/shadow-dom/slotchange.html#newcode43 third_party/WebKit/LayoutTests/shadow-dom/slotchange.html:43: }, 'A ...
4 years, 3 months ago (2016-09-02 04:08:10 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2306873002/40001
4 years, 3 months ago (2016-09-02 04:08:33 UTC) #17
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 3 months ago (2016-09-02 05:47:40 UTC) #18
commit-bot: I haz the power
4 years, 3 months ago (2016-09-02 05:49:49 UTC) #20
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/db300b7b07375236467cfcc9aad82b8f8affa36b
Cr-Commit-Position: refs/heads/master@{#416197}

Powered by Google App Engine
This is Rietveld 408576698