Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(68)

Unified Diff: scripts/slave/recipes/android/builder.py

Issue 2306853003: Add resource_sizes to chromium_perf steps for Android (Closed)
Patch Set: Revert steps.py for a follow-up Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: scripts/slave/recipes/android/builder.py
diff --git a/scripts/slave/recipes/android/builder.py b/scripts/slave/recipes/android/builder.py
index bdd89790b46f3f52c2d4ab2178a2b7592b0212cb..90e8ea204253b0c43b33fdd56f617480510492f7 100644
--- a/scripts/slave/recipes/android/builder.py
+++ b/scripts/slave/recipes/android/builder.py
@@ -55,6 +55,7 @@ BUILDERS = freeze({
'path': lambda api: ('Android Builder/full-build-linux_%s.zip'
% api.properties['revision']),
},
+ 'resource_sizes_apks': ['ChromePublic.apk', 'SystemWebView.apk'],
'run_mb': True,
'targets': [
'android_tools',
@@ -88,6 +89,7 @@ BUILDERS = freeze({
'Android arm64 Builder/full-build-linux_%s.zip'
% api.properties['revision']),
},
+ 'resource_sizes_apks': ['ChromePublic.apk', 'SystemWebView.apk'],
'run_mb': True,
'targets': [
'android_tools',
@@ -212,6 +214,10 @@ def _RunStepsInternal(api, mastername, buildername, revision):
droid.check_webview_licenses()
api.chromium.compile(bot_config.get('targets'))
+ for apk_name in bot_config.get('resource_sizes_apks', ()):
+ apk_path = api.chromium_android.apk_path(apk_name)
+ api.chromium_android.resource_sizes(apk_path, chartjson_file=True)
+
upload_config = bot_config.get('upload')
if upload_config:
droid.upload_build(upload_config['bucket'],

Powered by Google App Engine
This is Rietveld 408576698