cc: Prevent allocating memory buffers too large in tests.

cc: Prevent allocating memory buffers too large in tests.

We were OOMing a unit test on lollipop devices since we were using a
resource larger than MAX_TEXTURE_SIZE which is 2048, so we had a
bitmap of size:
  (100 * 2048 / 9.9, 15 * 2048 / 9.9)
= (20687, 3104)

Which is an ARGB32 bitmap so 4 bytes per pixel: 256,849,792 bytes.

With this patch we have
  (100 * 512 / 9.9, 15 * 512 / 9.9)
= (5172, 776)

Which is 4,013,472 which will fit in memory much easier.

R=enne
BUG=642333
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel

Committed: https://crrev.com/dd8e0f1980106ae0b0ff3ca86034b115c955d61b
Cr-Commit-Position: refs/heads/master@{#416289}

[danakj, 2016-09-02 01:08:39]

Description was changed from

==========
cc: Prevent allocating memory buffers too large in tests.

We were OOMing a unit test on lollipop devices since we were using a
resource larger than MAX_TEXTURE_SIZE which is 2048, so we had a
bitmap of size:
  (100 * 2048 / 9.9, 15 * 2048 / 9.9)
= (20687, 3104)

Which is an ARGB32 bitmap so 4 bytes per pixel: 256,849,792 bytes.

With this patch we have
  (100 * 512 / 9.9, 15 * 512 / 9.9)
= (5172, 776)

Which is 4,013,472 which will fit in memory much easier.

R=enne
BUG=642333
==========

to

==========
cc: Prevent allocating memory buffers too large in tests.

We were OOMing a unit test on lollipop devices since we were using a
resource larger than MAX_TEXTURE_SIZE which is 2048, so we had a
bitmap of size:
  (100 * 2048 / 9.9, 15 * 2048 / 9.9)
= (20687, 3104)

Which is an ARGB32 bitmap so 4 bytes per pixel: 256,849,792 bytes.

With this patch we have
  (100 * 512 / 9.9, 15 * 512 / 9.9)
= (5172, 776)

Which is 4,013,472 which will fit in memory much easier.

R=enne
BUG=642333
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

[danakj, 2016-09-02 01:10:11]

The CQ bit was checked by danakj@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-02 01:10:26]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[danakj, 2016-09-02 01:11:15]

The CQ bit was checked by danakj@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-02 01:11:26]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-02 02:02:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-02 02:02:22]

Dry run: This issue passed the CQ dry run.

[enne (OOO), 2016-09-02 17:20:54]

The CQ bit was checked by enne@chromium.org

[enne (OOO), 2016-09-02 17:20:55]

lgtm

[commit-bot: I haz the power, 2016-09-02 17:21:31]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-02 17:25:26]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-09-02 17:27:30]

Description was changed from

==========
cc: Prevent allocating memory buffers too large in tests.

We were OOMing a unit test on lollipop devices since we were using a
resource larger than MAX_TEXTURE_SIZE which is 2048, so we had a
bitmap of size:
  (100 * 2048 / 9.9, 15 * 2048 / 9.9)
= (20687, 3104)

Which is an ARGB32 bitmap so 4 bytes per pixel: 256,849,792 bytes.

With this patch we have
  (100 * 512 / 9.9, 15 * 512 / 9.9)
= (5172, 776)

Which is 4,013,472 which will fit in memory much easier.

R=enne
BUG=642333
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

to

==========
cc: Prevent allocating memory buffers too large in tests.

We were OOMing a unit test on lollipop devices since we were using a
resource larger than MAX_TEXTURE_SIZE which is 2048, so we had a
bitmap of size:
  (100 * 2048 / 9.9, 15 * 2048 / 9.9)
= (20687, 3104)

Which is an ARGB32 bitmap so 4 bytes per pixel: 256,849,792 bytes.

With this patch we have
  (100 * 512 / 9.9, 15 * 512 / 9.9)
= (5172, 776)

Which is 4,013,472 which will fit in memory much easier.

R=enne
BUG=642333
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel

Committed: https://crrev.com/dd8e0f1980106ae0b0ff3ca86034b115c955d61b
Cr-Commit-Position: refs/heads/master@{#416289}
==========

[commit-bot: I haz the power, 2016-09-02 17:27:31]

Patchset 2 (id:??) landed as
https://crrev.com/dd8e0f1980106ae0b0ff3ca86034b115c955d61b
Cr-Commit-Position: refs/heads/master@{#416289}

[jbudorick, 2016-09-02 17:38:06]

jbudorick@chromium.org changed reviewers:
+ jbudorick@chromium.org

[jbudorick, 2016-09-02 17:38:06]

A little late: fix verified on sprout.

[danakj, 2016-09-02 20:02:51]

On Fri, Sep 2, 2016 at 10:38 AM, <jbudorick@chromium.org> wrote:

> A little late: fix verified on sprout.
>

Thanks :)

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.