Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Issue 23068038: Fix phis for non-sse2 double values (Closed)

Created:
7 years, 3 months ago by oliv
Modified:
7 years, 3 months ago
Reviewers:
Toon Verwaest
CC:
v8-dev
Visibility:
Public.

Description

Fix phis for non-sse2 double values Since hydrogen will try to merge phi-inputs using registers, even if the values are spilled, we cannot mark LGoto as double clobbering instruction. BUG= R=verwaest@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=16671

Patch Set 1 : #

Total comments: 1

Patch Set 2 : address comment & rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+55 lines, -7 lines) Patch
M src/ia32/lithium-codegen-ia32.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M src/ia32/lithium-codegen-ia32.cc View 1 3 chunks +25 lines, -2 lines 0 comments Download
M src/ia32/lithium-ia32.h View 1 2 chunks +17 lines, -3 lines 0 comments Download
M src/ia32/lithium-ia32.cc View 1 3 chunks +12 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
oliv
7 years, 3 months ago (2013-09-04 09:36:08 UTC) #1
Toon Verwaest
lgtm with comment. Doesn't support two doubles yet, but I think it's ok to leave ...
7 years, 3 months ago (2013-09-11 12:28:30 UTC) #2
oliv
7 years, 3 months ago (2013-09-12 09:05:45 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as r16671 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698