Source/bindings/templates/callback_interface.cpp - Issue 23068032: Add constants and primitive type readonly attributes to Python IDL compiler

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/templates/callback_interface.cpp

Issue 23068032: Add constants and primitive type readonly attributes to Python IDL compiler (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Re-reupload Created 7 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/bindings/templates/callback_interface.cpp

diff --git a/Source/bindings/templates/callback_interface.cpp b/Source/bindings/templates/callback_interface.cpp

index 21a8969f9e0cbb249e993aca5cac66928f84a3ea..959789f6ce41972e3567a18119b4fedb616eeed9 100644

--- a/Source/bindings/templates/callback_interface.cpp

+++ b/Source/bindings/templates/callback_interface.cpp

@@ -69,7 +69,7 @@ namespace WebCore {

v8::Context::Scope scope(v8Context);

{% for argument in method.arguments %}

- {{argument.cpp_to_js_conversion | indent(4)}}

+ {{argument.cpp_to_v8_conversion | indent}}

if ({{argument.name}}Handle.IsEmpty()) {

if (!isScriptControllerTerminating())

CRASH();

« no previous file with comments | « Source/bindings/templates/attributes.cpp ('k') | Source/bindings/templates/constants.cpp » ('j') | no next file with comments »