Add constants and primitive type readonly attributes to Python IDL compiler

Source/bindings/tests/results/V8TestConstants.cpp

Index: Source/bindings/tests/results/V8TestConstants.cpp
diff --git a/Source/bindings/tests/results/V8TestConstants.cpp b/Source/bindings/tests/results/V8TestConstants.cpp
new file mode 100644
index 0000000000000000000000000000000000000000..6398da0b2998a39c07b53704a1e329830179e56a
--- /dev/null
+++ b/Source/bindings/tests/results/V8TestConstants.cpp
@@ -0,0 +1,191 @@
+/*
+    This file is part of the Blink open source project.
+    This file has been auto-generated by CodeGeneratorV8.pm. DO NOT MODIFY!
+
+    This library is free software; you can redistribute it and/or
+    modify it under the terms of the GNU Library General Public
+    License as published by the Free Software Foundation; either
+    version 2 of the License, or (at your option) any later version.
+
+    This library is distributed in the hope that it will be useful,
+    but WITHOUT ANY WARRANTY; without even the implied warranty of
+    MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
+    Library General Public License for more details.
+
+    You should have received a copy of the GNU Library General Public License
+    along with this library; see the file COPYING.LIB.  If not, write to
+    the Free Software Foundation, Inc., 59 Temple Place - Suite 330,
+    Boston, MA 02111-1307, USA.
+*/
+
+#include "config.h"
+#include "V8TestConstants.h"
+
+#include "RuntimeEnabledFeatures.h"
+#include "bindings/v8/ScriptController.h"
+#include "bindings/v8/V8Binding.h"
+#include "bindings/v8/V8DOMConfiguration.h"
+#include "bindings/v8/V8DOMWrapper.h"
+#include "core/dom/ContextFeatures.h"
+#include "core/dom/Document.h"
+#include "core/page/Frame.h"
+#include "core/platform/chromium/TraceEvent.h"
+#include "wtf/UnusedParam.h"
+
+namespace WebCore {
+
+static void initializeScriptWrappableForInterface(TestConstants* object)
+{
+    if (ScriptWrappable::wrapperCanBeStoredInObject(object))
+        ScriptWrappable::setTypeInfoInObject(object, &V8TestConstants::info);
+    else
+        ASSERT_NOT_REACHED();
+}
+
+} // namespace WebCore
+
+// In ScriptWrappable::init, the use of a local function declaration has an issue on Windows:
+// the local declaration does not pick up the surrounding namespace. Therefore, we provide this function
+// in the global namespace.
+// (More info on the MSVC bug here: http://connect.microsoft.com/VisualStudio/feedback/details/664619/the-namespace-of-local-function-declarations-in-c)
+void webCoreInitializeScriptWrappableForInterface(WebCore::TestConstants* object)
+{
+    WebCore::initializeScriptWrappableForInterface(object);
+}
+
+namespace WebCore {
+WrapperTypeInfo V8TestConstants::info = { V8TestConstants::GetTemplate, V8TestConstants::derefObject, 0, 0, 0, V8TestConstants::installPerContextPrototypeProperties, 0, WrapperTypeObjectPrototype };
+
+namespace TestConstantsV8Internal {
+
+template <typename T> void V8_USE(T) { }
+
+} // namespace TestConstantsV8Internal
+
+static const V8DOMConfiguration::ConstantConfiguration V8TestConstantsConstants[] = {
+    {"CONST_VALUE_0", 0},
+    {"CONST_VALUE_1", 1},
+    {"CONST_VALUE_2", 2},
+    {"CONST_VALUE_4", 4},
+    {"CONST_VALUE_8", 8},
+    {"CONST_VALUE_9", -1},
+    {"CONST_VALUE_10", "my constant string"},
+    {"CONST_VALUE_11", 0xffffffff},
+    {"CONST_VALUE_12", 0x01},
+    {"CONST_VALUE_13", 0X20},
+    {"CONST_VALUE_14", 0x1abc},
+    {"CONST_VALUE_15", 010},
+    {"CONST_VALUE_16", -010},
+    {"CONST_VALUE_16", -0x1A},
+    {"CONST_VALUE_17", -0X1a},
+#if ENABLE(Condition)
+    {"CONDITIONAL_CONST", 0},
+#endif // ENABLE(Condition)
+    {"DEPRECATED_CONSTANT", 1},
+    {"CONST_JAVASCRIPT", 1},
+};
+
+COMPILE_ASSERT(0 == TestConstants::CONST_VALUE_0, TestConstantsEnumCONST_VALUE_0IsWrongUseDoNotCheckConstants);
+COMPILE_ASSERT(1 == TestConstants::CONST_VALUE_1, TestConstantsEnumCONST_VALUE_1IsWrongUseDoNotCheckConstants);
+COMPILE_ASSERT(2 == TestConstants::CONST_VALUE_2, TestConstantsEnumCONST_VALUE_2IsWrongUseDoNotCheckConstants);
+COMPILE_ASSERT(4 == TestConstants::CONST_VALUE_4, TestConstantsEnumCONST_VALUE_4IsWrongUseDoNotCheckConstants);
+COMPILE_ASSERT(8 == TestConstants::CONST_VALUE_8, TestConstantsEnumCONST_VALUE_8IsWrongUseDoNotCheckConstants);
+COMPILE_ASSERT(-1 == TestConstants::CONST_VALUE_9, TestConstantsEnumCONST_VALUE_9IsWrongUseDoNotCheckConstants);
+COMPILE_ASSERT("my constant string" == TestConstants::CONST_VALUE_10, TestConstantsEnumCONST_VALUE_10IsWrongUseDoNotCheckConstants);
+COMPILE_ASSERT(0xffffffff == TestConstants::CONST_VALUE_11, TestConstantsEnumCONST_VALUE_11IsWrongUseDoNotCheckConstants);
+COMPILE_ASSERT(0x01 == TestConstants::CONST_VALUE_12, TestConstantsEnumCONST_VALUE_12IsWrongUseDoNotCheckConstants);
+COMPILE_ASSERT(0X20 == TestConstants::CONST_VALUE_13, TestConstantsEnumCONST_VALUE_13IsWrongUseDoNotCheckConstants);
+COMPILE_ASSERT(0x1abc == TestConstants::CONST_VALUE_14, TestConstantsEnumCONST_VALUE_14IsWrongUseDoNotCheckConstants);
+COMPILE_ASSERT(010 == TestConstants::CONST_VALUE_15, TestConstantsEnumCONST_VALUE_15IsWrongUseDoNotCheckConstants);
+COMPILE_ASSERT(-010 == TestConstants::CONST_VALUE_16, TestConstantsEnumCONST_VALUE_16IsWrongUseDoNotCheckConstants);
+COMPILE_ASSERT(-0x1A == TestConstants::CONST_VALUE_16, TestConstantsEnumCONST_VALUE_16IsWrongUseDoNotCheckConstants);
+COMPILE_ASSERT(-0X1a == TestConstants::CONST_VALUE_17, TestConstantsEnumCONST_VALUE_17IsWrongUseDoNotCheckConstants);
+#if ENABLE(Condition)
+COMPILE_ASSERT(0 == TestConstants::CONDITIONAL_CONST, TestConstantsEnumCONDITIONAL_CONSTIsWrongUseDoNotCheckConstants);
+#endif // ENABLE(Condition)
+COMPILE_ASSERT(1 == TestConstants::DEPRECATED_CONSTANT, TestConstantsEnumDEPRECATED_CONSTANTIsWrongUseDoNotCheckConstants);
+COMPILE_ASSERT(1 == TestConstants::RUNTIME_ENABLED_CONST, TestConstantsEnumRUNTIME_ENABLED_CONSTIsWrongUseDoNotCheckConstants);
+COMPILE_ASSERT(1 == TestConstants::FEATURE_ENABLED_CONST, TestConstantsEnumFEATURE_ENABLED_CONSTIsWrongUseDoNotCheckConstants);
+COMPILE_ASSERT(1 == TestConstants::CONST_IMPL, TestConstantsEnumCONST_IMPLIsWrongUseDoNotCheckConstants);
+
+static v8::Handle<v8::FunctionTemplate> ConfigureV8TestConstantsTemplate(v8::Handle<v8::FunctionTemplate> desc, v8::Isolate* isolate, WrapperWorldType currentWorldType)

[haraken, 2013/08/26 09:33:40]

ConfigureV8TestConstantsTemplate => InstallDOMClassTemplate ? (consistency with
installDOMClassTemplate)

[Nils Barth (inactive), 2013/08/27 02:59:27]

This function actually returns a template; most of the install* functions are
void
(i.e., they just install), so this feels different.

+{
+    desc->ReadOnlyPrototype();
+
+    v8::Local<v8::Signature> defaultSignature;
+    defaultSignature = V8DOMConfiguration::installDOMClassTemplate(desc, "TestConstants", v8::Local<v8::FunctionTemplate>(), V8TestConstants::internalFieldCount,
+        0, 0,
+        0, 0, isolate, currentWorldType);
+    UNUSED_PARAM(defaultSignature); // In some cases, it will not be used.
+    v8::Local<v8::ObjectTemplate> instance = desc->InstanceTemplate();
+    v8::Local<v8::ObjectTemplate> proto = desc->PrototypeTemplate();
+    UNUSED_PARAM(instance); // In some cases, it will not be used.
+    UNUSED_PARAM(proto); // In some cases, it will not be used.
+    if (RuntimeEnabledFeatures::rUNTIME_ENABLED_CONSTEnabled()) {

[haraken, 2013/08/26 09:33:40]

"rUNTIME" looks wrong.

[Nils Barth (inactive), 2013/08/27 02:59:27]

It's pretty ugly, because the CG assumes CamelCase, which isn't true for
constants.
This requires a Perl change too; I'll do in followup.

+        static const V8DOMConfiguration::ConstantConfiguration constantConfiguration = {"RUNTIME_ENABLED_CONST", static_cast<signed int>(1)};
+        V8DOMConfiguration::installConstants(desc, proto, &constantConfiguration, 1, isolate);
+    }
+    if (RuntimeEnabledFeatures::featureNameEnabled()) {
+        static const V8DOMConfiguration::ConstantConfiguration constantConfiguration = {"FEATURE_ENABLED_CONST", static_cast<signed int>(1)};
+        V8DOMConfiguration::installConstants(desc, proto, &constantConfiguration, 1, isolate);
+    }
+    V8DOMConfiguration::installConstants(desc, proto, V8TestConstantsConstants, WTF_ARRAY_LENGTH(V8TestConstantsConstants), isolate);
+
+    // Custom toString template
+    desc->Set(v8::String::NewSymbol("toString"), V8PerIsolateData::current()->toStringTemplate());
+    return desc;
+}
+
+v8::Handle<v8::FunctionTemplate> V8TestConstants::GetTemplate(v8::Isolate* isolate, WrapperWorldType currentWorldType)
+{
+    V8PerIsolateData* data = V8PerIsolateData::from(isolate);
+    V8PerIsolateData::TemplateMap::iterator result = data->templateMap(currentWorldType).find(&info);
+    if (result != data->templateMap(currentWorldType).end())
+        return result->value.newLocal(isolate);
+
+    TRACE_EVENT_SCOPED_SAMPLING_STATE("Blink", "BuildDOMTemplate");
+    v8::HandleScope handleScope(isolate);
+    v8::Handle<v8::FunctionTemplate> templ =
+        ConfigureV8TestConstantsTemplate(data->rawTemplate(&info, currentWorldType), isolate, currentWorldType);
+    data->templateMap(currentWorldType).add(&info, UnsafePersistent<v8::FunctionTemplate>(isolate, templ));
+    return handleScope.Close(templ);
+}
+
+bool V8TestConstants::HasInstance(v8::Handle<v8::Value> value, v8::Isolate* isolate, WrapperWorldType currentWorldType)
+{
+    return V8PerIsolateData::from(isolate)->hasInstance(&info, value, currentWorldType);
+}
+
+bool V8TestConstants::HasInstanceInAnyWorld(v8::Handle<v8::Value> value, v8::Isolate* isolate)
+{
+    return V8PerIsolateData::from(isolate)->hasInstance(&info, value, MainWorld)
+        || V8PerIsolateData::from(isolate)->hasInstance(&info, value, IsolatedWorld)
+        || V8PerIsolateData::from(isolate)->hasInstance(&info, value, WorkerWorld);
+}
+
+v8::Handle<v8::Object> V8TestConstants::createWrapper(PassRefPtr<TestConstants> impl, v8::Handle<v8::Object> creationContext, v8::Isolate* isolate)
+{
+    ASSERT(impl.get());
+    ASSERT(!DOMDataStore::containsWrapper<V8TestConstants>(impl.get(), isolate));
+    if (ScriptWrappable::wrapperCanBeStoredInObject(impl.get())) {
+        const WrapperTypeInfo* actualInfo = ScriptWrappable::getTypeInfoFromObject(impl.get());
+        // Might be a XXXConstructor::info instead of an XXX::info. These will both have
+        // the same object de-ref functions, though, so use that as the basis of the check.
+        RELEASE_ASSERT_WITH_SECURITY_IMPLICATION(actualInfo->derefObjectFunction == info.derefObjectFunction);
+    }
+
+    v8::Handle<v8::Object> wrapper = V8DOMWrapper::createWrapper(creationContext, &info, toInternalPointer(impl.get()), isolate);
+    if (UNLIKELY(wrapper.IsEmpty()))
+        return wrapper;
+
+    installPerContextProperties(wrapper, impl.get(), isolate);
+    V8DOMWrapper::associateObjectWithWrapper<V8TestConstants>(impl, &info, wrapper, isolate, WrapperConfiguration::Independent);
+    return wrapper;
+}
+
+void V8TestConstants::derefObject(void* object)
+{
+    fromInternalPointer(object)->deref();
+}
+
+} // namespace WebCore