Add constants and primitive type readonly attributes to Python IDL compiler

Source/bindings/tests/idls/TestConstants.idl

 /*
  * Copyright (C) 2013 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 10 matching lines @@
  * A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
  * OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
  * SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
  * LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
  * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
  * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
  * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
  * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
  */
 
-#ifndef ExceptionMessages_h
-#define ExceptionMessages_h
+interface TestConstants {
+    const unsigned short CONST_VALUE_0 = 0;

[haraken, 2013/08/26 09:33:40]

CONST_VALUE_0 => ConstValue0 (according to Blink coding style)

[Nils Barth (inactive), 2013/08/27 02:59:27]

Constants in IDL files are generally UPPER_CASE.
See:
http://www.w3.org/TR/WebIDL/#idl-constants
and:
git grep const -- '*.idl'

+    const unsigned short CONST_VALUE_1 = 1;
+    const unsigned short CONST_VALUE_2 = 2;
+    const unsigned short CONST_VALUE_4 = 4;
+    const unsigned short CONST_VALUE_8 = 8;
+    const short CONST_VALUE_9 = -1;
+    const DOMString CONST_VALUE_10 = "my constant string";
+    const unsigned short CONST_VALUE_11 = 0xffffffff;
+    const unsigned short CONST_VALUE_12 = 0x01;
+    const unsigned short CONST_VALUE_13 = 0X20;
+    const unsigned short CONST_VALUE_14 = 0x1abc;
+    const unsigned short CONST_VALUE_15 = 010;
+    const unsigned short CONST_VALUE_16 = -010;
+    const unsigned short CONST_VALUE_16 = -0x1A;
+    const unsigned short CONST_VALUE_17 = -0X1a;
 
-#include "wtf/text/WTFString.h"
-
-namespace WebCore {
-
-class ExceptionMessages {
-public:
-    static String failedToExecute(const String& method, const String& type, const String& detail = String());
-    static String failedToGet(const String& property, const String& type, const String& detail);
-    static String failedToSet(const String& property, const String& type, const String& detail);
+    // Extended attributes
+    [Conditional=Condition] const short CONDITIONAL_CONST = 0;
+    [DeprecateAs=Constant] const short DEPRECATED_CONSTANT = 1;
+    [EnabledAtRuntime] const short RUNTIME_ENABLED_CONST = 1;
+    [EnabledAtRuntime=FeatureName] const short FEATURE_ENABLED_CONST = 1;
+    [Reflect=CONST_IMPL] const short CONST_JAVASCRIPT = 1;

[haraken, 2013/08/26 09:33:40]

You can keep these tests in TestObject.idl. We might not want to increase the
number of test files because it just increases diff when reviewing. (e.g., toV8
family is generated to each test result file.)

[Nils Barth (inactive), 2013/08/27 02:59:27]

I need to split them out for Python to test them (>.<)
(since Python doesn't pass the rest of TestObject.idl).
We already have this problem, and it's inevitable (unless we have only one test
file), due to lack of orthogonality in always-used features.
We can split most features into small unit tests, but basic changes change
everything :(

Best solution is to have some very basic files (like TestInterfaceEmpty.idl) to
make it easy to review these basic changes, and then we can just skip the others
to check that it's the same change:
it's a bit of noise but it's easy to check that it's just the same 2 line
change.

Also any *basic* change (e.g., toV8, getters) should be in a separate CL anyway
exactly b/c it's spread throughout, so we want to be sure that's the only
change.

[haraken, 2013/08/27 03:39:00]

That said, until we have a good framework for unit-testing, we don't want to
have TestAttributes.idl, TestOperations.idl etc. It just makes reviewing
annoying. We can put all basic tests into TestObject.idl.

As we've discussed, bindings-tests are not well organized (It's just for
reviewing). Thus we don't want to speed down our work by trying hard to make
bindings-tests workable. (Also, bindings-tests can confuse other developers who
want to modify the generators in the intermediate state.) I'm even OK with
landing the new Python generator without any bindings-tests. You can just verify
that the Python generator generates exactly the same code for real IDL files.

 };
-
-} // namespace WebCore
-
-#endif // ExceptionMessages_h