Add constants and primitive type readonly attributes to Python IDL compiler

Source/bindings/templates/constants.cpp

+{# FIXME: remove all the conditional_string blocks once test removed #}
+{# FIXME: should use name_reflect instead of name #}
+{# FIXME: do we need separate value and value_raw? #}
+{% macro class_consts() %}

[haraken, 2013/08/22 07:31:33]

class_consts => define_constants

[Nils Barth (inactive), 2013/08/22 09:08:13]

(See above.)

+static const V8DOMConfiguration::BatchedConstant {{v8_class_name}}Consts[] = {

[haraken, 2013/08/22 07:31:33]

{{v8_class_name}}Consts[] => {{v8_class_name}}Constants[]

[Nils Barth (inactive), 2013/08/22 09:08:13]

(Perl.)

+{% for constant in constants %}
+{% if not constant.enabled_at_runtime %}
+{% if constant.conditional_string %}
+#if {{constant.conditional_string}}
+{% endif %}
+    {"{{constant.name}}", {{constant.value}}},
+{% if constant.conditional_string %}
+#endif // {{constant.conditional_string}}
+{% endif %}
+{% endif %}{# not constant.enabled_at_runtime #}
+{% endfor %}
+};
+{% if not do_not_check_constants %}
+
+

[haraken, 2013/08/22 07:31:33]

Nit: Unnecessary empty line.

[Nils Barth (inactive), 2013/08/22 09:08:13]

(Perl.)

+{% for constant in constants %}
+{% if constant.conditional_string %}
+#if {{constant.conditional_string}}
+{% endif %}
+COMPILE_ASSERT({{constant.value_raw}} == {{cpp_class_name}}::{{constant.name_reflect}}, {{cpp_class_name}}Enum{{constant.name_reflect}}IsWrongUseDoNotCheckConstants);

[haraken, 2013/08/22 07:31:33]

{{cpp_class_name}}Enum{{constant.name_reflect}}IsWrongUseDoNotCheckConstants =>
TheValueOf{{cpp_class_name}}::{{constant.name_reflect}}Doesn'tMatchWithImplementation

[Nils Barth (inactive), 2013/08/22 09:08:13]

Perl.
...and should:
Doesn'tMatchWithImplementation
...be:
DoesntMatchWithImplementation
(no ' ?)

+{% if constant.conditional_string %}
+#endif // {{constant.conditional_string}}
+{% endif %}
+{% endfor %}
+{% endif %}{# not do_not_check_constants #}
+{% endmacro %}{# class_consts #}
+
+
+{##############################################################################}
+{% macro const_data(constant) %}

[haraken, 2013/08/22 07:31:33]

const_data => install_runtime_enabled_constant

[Nils Barth (inactive), 2013/08/22 09:08:13]

(See above.)

+{% if constant.enabled_at_runtime %}
+{% if constant.conditional_string %}
+#if {{constant.conditional_string}}
+{% endif %}
+    if ({{constant.enable_function}}()) {
+        static const V8DOMConfiguration::BatchedConstant constData = {"{{constant.name}}", static_cast<signed int>({{constant.value}})};

[haraken, 2013/08/22 07:31:33]

constData => constantConfiguration ?

[Nils Barth (inactive), 2013/08/22 09:08:13]

I *think* the "Configuration" is just for initialization; after that we should
just think of it as data.

[haraken, 2013/08/22 11:05:28]

This is used just for initialization. That's the reason why I want to rename it
to "Configuration" :) At the same time, I want to rename "Batch" to "Install" to
make it clearer.

[Nils Barth (inactive), 2013/08/23 01:50:05]

Got it, will do!

+        V8DOMConfiguration::batchConfigureConstants(desc, proto, &constData, 1, isolate);
+    }
+{% if constant.conditional_string %}
+#endif // {{constant.conditional_string}}
+{%- endif %}

[haraken, 2013/08/22 07:31:33]

Ditto. What is the '-' ?

[Nils Barth (inactive), 2013/08/22 09:08:13]

It removes trailing whitespace; I'm using it here so we can have the endif on a
separate line (for clarity), otherwise it would read:
{% if constant.conditional_string %}
#endif // {{constant.conditional_string}}{% endif %}

There used to be a *huge* number of these all over the templates, but I've
reduced it to only the necessary ones (or clarity, like here); this simplifies
the templates a lot and means we exactly match the Perl linebreaks too (except
in one place where I'll want to fix the Perl CG, as there's an indented blank
line). (It wasn't much work, once I understood how it worked.)

An overall "FIXME" is to remove all of these once we've removed Perl, but it's a
huge waste of time to fix whitespace in the Perl CG!

+{% endif %}
+{% endmacro %}{# const_data #}
+
+
+{##############################################################################}
+{% macro batch_configure_constants() %}

[haraken, 2013/08/22 07:31:33]

batch_configure_constants => install_constants

[Nils Barth (inactive), 2013/08/22 09:08:13]

(See above.)

+V8DOMConfiguration::batchConfigureConstants(desc, proto, {{v8_class_name}}Consts, WTF_ARRAY_LENGTH({{v8_class_name}}Consts), isolate);

[haraken, 2013/08/22 07:31:33]

Probably we want to rename the method to installConstants.

[Nils Barth (inactive), 2013/08/22 09:08:13]

FIXME added!

+{%- endmacro %}