Add constants and primitive type readonly attributes to Python IDL compiler

Source/bindings/templates/attributes.cpp

+{% macro attribute_getter(attribute) %}

[haraken, 2013/08/22 07:31:33]

attribute_getter => define_attribute_getter

[Nils Barth (inactive), 2013/08/22 09:08:13]

For functions, I agree that verb names are better,
but for template macros it's clearer to have the macro name agree with the
content,
since it's declarative, so AttrGetter -> attr_getter (changed for consistency).

+static void {{attribute.name}}AttrGetter(v8::Local<v8::String> name, const v8::PropertyCallbackInfo<v8::Value>& info)
+{
+    {{cpp_class_name}}* imp = {{v8_class_name}}::toNative(info.Holder());
+{% if attribute.should_keep_attribute_alive %}
+    {{attribute_return_keep_property_alive(attribute) | indent}}
+{% else %}
+    {{attribute.return_js_value_statement | indent}}
+{% endif %}
+    return;
+}
+
+{% endmacro %}
+
+
+{##############################################################################}
+{% macro attribute_return_keep_property_alive(attribute) %}

[haraken, 2013/08/22 07:31:33]

attribute_return_keep_property_alive => keep_attribute_alive

It looks like we can make the naming consistent by starting the name from a
verb.

[Nils Barth (inactive), 2013/08/22 09:08:13]

For these block templates, I'm not sure how to name them;
something like "the effective statement".
Here the bottom line seems to be set_return, but we want to keep it alive.
Also, we know it's an attribute, so how about set_return_keep_alive?

+{{attribute.cpp_type}} result = imp->{{attribute.cpp_method_name}}();
+if (result.get() && DOMDataStore::setReturnValueFromWrapper<{{attribute.v8_type}}>(info.GetReturnValue(), result.get()))
+    return;
+v8::Handle<v8::Value> wrapper = toV8(result.get(), info.Holder(), info.GetIsolate());
+if (!wrapper.IsEmpty()) {
+    V8HiddenPropertyName::setNamedHiddenReference(info.Holder(), "{{attribute.name}}", wrapper);
+    v8SetReturnValue(info, wrapper);
+}
+{% endmacro %}
+
+
+{##############################################################################}
+{% macro attribute_getter_callback(attribute) %}

[haraken, 2013/08/22 07:31:33]

attribute_getter_callback => define_attribute_getter_callback

[Nils Barth (inactive), 2013/08/22 09:08:13]

(As above, declarative template, not function.)

+static void {{attribute.name}}AttrGetterCallback(v8::Local<v8::String> name, const v8::PropertyCallbackInfo<v8::Value>& info)
+{
+    TRACE_EVENT_SET_SAMPLING_STATE("Blink", "DOMGetter");
+    {{cpp_class_name}}V8Internal::{{attribute.name}}AttrGetter(name, info);
+    TRACE_EVENT_SET_SAMPLING_STATE("V8", "Execution");
+}
+
+{% endmacro %}
+
+
+{##############################################################################}
+{% macro batched_attribute() %}

[haraken, 2013/08/22 07:31:33]

batched_attribute => install_attributes

"Batched" sounds a bit unclear. "Install" would be better.

[Nils Barth (inactive), 2013/08/22 09:08:13]

I'm naming the macros after what they define (per above), so given name
{{v8_class_name}}Attrs,
actually class_attrs is better (confused type vs. name).

[haraken, 2013/08/22 11:05:28]

I'm suggesting naming everything consistently. For example, the fact that you
use "attributes" in the code generator but use "attrs" in the template is
inconsistent.

- You can rename V8DOMConfiguraton::BatchedAttribute to
V8DOMConfiguration::InstalledAttributes.
- You can rename {{v8_class_name}}Attrs[] to {{v8_class_name}}Attributes.
- You can rename class_attrs to installed_attributes

etc.

[Nils Barth (inactive), 2013/08/23 01:50:05]

Got it, will change in Perl first, then update this.

+static const V8DOMConfiguration::BatchedAttribute {{v8_class_name}}Attrs[] = {

[haraken, 2013/08/22 07:31:33]

{{v8_class_name}}Attrs[] => {{v8_class_name}}Attributes[]

[Nils Barth (inactive), 2013/08/22 09:08:13]

(Perl compatibility.)

+{% for attribute in attributes %}
+    // Attribute '{{attribute.name}}'

[haraken, 2013/08/22 07:31:33]

You can remove this comment.

[Nils Barth (inactive), 2013/08/22 09:08:13]

(Perl compatibility.)

+    {"{{attribute.name}}", {{cpp_class_name}}V8Internal::{{attribute.name}}AttrGetterCallback, 0, 0, 0, 0 /* no data */, static_cast<v8::AccessControl>(v8::DEFAULT), static_cast<v8::PropertyAttribute>(v8::None), 0 /* on instance */},

[haraken, 2013/08/22 07:31:33]

You can remove /*no data*/. It isn't helpful.

[Nils Barth (inactive), 2013/08/22 09:08:13]

(Perl compatibility.)

+{% endfor %}
+};
+{% endmacro %}