Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3354)

Unified Diff: chrome/browser/resources/hotword/nacl_manager.js

Issue 2306803003: Hotword: Fix always-on case by removing MS_CONFIGURED timeout (Closed)
Patch Set: Hotword: Fix always-on case by removing MS_CONFIGURED timeout Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/resources/hotword/nacl_manager.js
diff --git a/chrome/browser/resources/hotword/nacl_manager.js b/chrome/browser/resources/hotword/nacl_manager.js
index 4b10183b5eb519df1ee77745c7f229515772b0bb..5a1dd556523b477838dc7c0d2543c8e7f54e45fd 100644
--- a/chrome/browser/resources/hotword/nacl_manager.js
+++ b/chrome/browser/resources/hotword/nacl_manager.js
@@ -460,8 +460,12 @@ NaClManager.prototype.handleModelLoaded_ = function() {
return;
}
this.sendDataToPlugin_(this.stream_.getAudioTracks()[0]);
- this.waitForMessage_(hotword.constants.TimeoutMs.LONG,
- hotword.constants.NaClPlugin.MS_CONFIGURED);
+ // The plugin will send a MS_CONFIGURED, but don't set a timeout waiting for
+ // it. MediaStreamAudioTrack::Configure() will remain pending until the first
+ // audio buffer is received. When the audio source is a DSP for always-on
+ // detection, no audio sample is sent until the DSP detects a potential
+ // hotword trigger. Thus, Configure would remain pending indefinitely if we
+ // were to wait here. See https://crbug.com/616203
};
/**
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698