Source/core/platform/image-decoders/gif/GIFImageReader.cpp - Issue 23068027: Animated WebP: Optimize decoding in case of seeking

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/platform/image-decoders/gif/GIFImageReader.cpp

Issue 23068027: Animated WebP: Optimize decoding in case of seeking (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@add_noblend_image

Patch Set: Fix assert fail on debug Created 7 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « Source/core/platform/image-decoders/gif/GIFImageReader.h ('k') | Source/core/platform/image-decoders/webp/WEBPImageDecoder.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/platform/image-decoders/gif/GIFImageReader.cpp

diff --git a/Source/core/platform/image-decoders/gif/GIFImageReader.cpp b/Source/core/platform/image-decoders/gif/GIFImageReader.cpp

index a26a7f5d7069e47fd10cc4afccd365c7608ddec1..7716cedef363aebbee4eca7cfb9af0389a219161 100644

--- a/Source/core/platform/image-decoders/gif/GIFImageReader.cpp

+++ b/Source/core/platform/image-decoders/gif/GIFImageReader.cpp

@@ -556,7 +556,7 @@ bool GIFImageReader::parseData(size_t dataPosition, size_t len, GIFImageDecoder:

// NOTE: This relies on the values in the FrameDisposalMethod enum

// matching those in the GIF spec!

int disposalMethod = ((*currentComponent) >> 2) & 0x7;

- currentFrame->setDisposalMethod(static_cast<WebCore::ImageFrame::FrameDisposalMethod>(disposalMethod));

+ currentFrame->setDisposalMethod(static_cast<WebCore::ImageFrame::DisposalMethod>(disposalMethod));

// Some specs say that disposal method 3 is "overwrite previous", others that setting

// the third bit of the field (i.e. method 4) is. We map both to the same value.

if (disposalMethod == 4)