Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(107)

Issue 23068021: Remove PerBrowser launcher, reland step 1 of 2 (Closed)

Created:
7 years, 4 months ago by James Cook
Modified:
7 years, 4 months ago
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org, tfarina, sadrul, ben+watch_chromium.org, simonhong_
Visibility:
Public.

Description

Remove PerBrowser launcher, reland step 1 of 2 Relanding https://chromiumcodereview.appspot.com/22887015/ in two steps to preserve history of c/b/ui/ash/launcher/chrome_launcher_controller_per_app.* Step 2 will rename chrome_launcher_controller_per_app.* to chrome_launcher_controller.* Original description: Remove per-browser.* and related tests. Remove IsPerAppLauncher() interface in LauncherDelegate. Remove ash-disable-per-app-launcher switch. Change class name from ChromeLauncherControllerPerApp to ChromeLauncherController. In the next CL, BrowserLauncherItemController will be replaced with new browser status monitor only for monitoring browser and tab status. BUG=169303 TEST=unit_tests, browser_tests Launcher* TBR=skuhne@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=218945

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+700 lines, -4733 lines) Patch
M ash/ash_switches.h View 1 chunk +0 lines, -1 line 0 comments Download
M ash/ash_switches.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M ash/launcher/launcher.h View 1 chunk +0 lines, -2 lines 0 comments Download
M ash/launcher/launcher.cc View 1 chunk +1 line, -4 lines 0 comments Download
M ash/launcher/launcher_delegate.h View 2 chunks +1 line, -4 lines 0 comments Download
M ash/shell/launcher_delegate_impl.h View 1 chunk +0 lines, -1 line 0 comments Download
M ash/shell/launcher_delegate_impl.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M ash/test/test_launcher_delegate.h View 1 chunk +0 lines, -1 line 0 comments Download
M ash/test/test_launcher_delegate.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/app/generated_resources.grd View 1 chunk +0 lines, -6 lines 0 comments Download
M chrome/browser/about_flags.cc View 1 chunk +0 lines, -7 lines 0 comments Download
M chrome/browser/ui/ash/app_list/app_list_controller_ash.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/ash/app_list/app_list_service_ash.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/ash/chrome_shell_delegate.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/ash/launcher/app_shortcut_launcher_item_controller.h View 3 chunks +6 lines, -3 lines 0 comments Download
M chrome/browser/ui/ash/launcher/app_shortcut_launcher_item_controller.cc View 10 chunks +16 lines, -14 lines 0 comments Download
M chrome/browser/ui/ash/launcher/browser_launcher_item_controller.cc View 6 chunks +9 lines, -67 lines 0 comments Download
D chrome/browser/ui/ash/launcher/browser_launcher_item_controller_unittest.cc View 1 chunk +0 lines, -543 lines 0 comments Download
M chrome/browser/ui/ash/launcher/browser_shortcut_launcher_item_controller.h View 2 chunks +3 lines, -6 lines 0 comments Download
M chrome/browser/ui/ash/launcher/browser_shortcut_launcher_item_controller.cc View 5 chunks +7 lines, -7 lines 0 comments Download
M chrome/browser/ui/ash/launcher/chrome_launcher_app_menu_item_browser.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/ash/launcher/chrome_launcher_app_menu_item_tab.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/ash/launcher/chrome_launcher_app_menu_item_v2app.h View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/ash/launcher/chrome_launcher_app_menu_item_v2app.cc View 1 chunk +1 line, -1 line 0 comments Download
D chrome/browser/ui/ash/launcher/chrome_launcher_controller.h View 1 chunk +0 lines, -310 lines 0 comments Download
D chrome/browser/ui/ash/launcher/chrome_launcher_controller.cc View 1 chunk +0 lines, -39 lines 0 comments Download
D chrome/browser/ui/ash/launcher/chrome_launcher_controller_browsertest.cc View 1 chunk +0 lines, -837 lines 0 comments Download
M chrome/browser/ui/ash/launcher/chrome_launcher_controller_per_app.h View 10 chunks +140 lines, -134 lines 0 comments Download
M chrome/browser/ui/ash/launcher/chrome_launcher_controller_per_app.cc View 66 chunks +135 lines, -155 lines 0 comments Download
M chrome/browser/ui/ash/launcher/chrome_launcher_controller_per_app_browsertest.cc View 48 chunks +168 lines, -119 lines 0 comments Download
M chrome/browser/ui/ash/launcher/chrome_launcher_controller_per_app_unittest.cc View 34 chunks +186 lines, -43 lines 0 comments Download
D chrome/browser/ui/ash/launcher/chrome_launcher_controller_per_browser.h View 1 chunk +0 lines, -430 lines 0 comments Download
D chrome/browser/ui/ash/launcher/chrome_launcher_controller_per_browser.cc View 1 chunk +0 lines, -1476 lines 0 comments Download
D chrome/browser/ui/ash/launcher/chrome_launcher_controller_per_browser_unittest.cc View 1 chunk +0 lines, -462 lines 0 comments Download
M chrome/browser/ui/ash/launcher/launcher_app_tab_helper.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/ash/launcher/launcher_application_menu_item_model.h View 1 chunk +6 lines, -1 line 0 comments Download
M chrome/browser/ui/ash/launcher/launcher_application_menu_item_model.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/ash/launcher/launcher_context_menu.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/ash/launcher/launcher_context_menu_unittest.cc View 2 chunks +6 lines, -10 lines 0 comments Download
M chrome/browser/ui/ash/launcher/launcher_item_controller.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/ash/launcher/shell_window_launcher_controller.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/ash/launcher/shell_window_launcher_item_controller.cc View 4 chunks +2 lines, -18 lines 0 comments Download
M chrome/chrome_browser_ui.gypi View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/chrome_tests.gypi View 2 chunks +0 lines, -2 lines 0 comments Download
M chrome/chrome_tests_unit.gypi View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jamescook@chromium.org/23068021/1
7 years, 4 months ago (2013-08-21 21:36:45 UTC) #1
commit-bot: I haz the power
Retried try job too often on linux_rel for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&number=161332
7 years, 4 months ago (2013-08-22 01:19:46 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jamescook@chromium.org/23068021/1
7 years, 4 months ago (2013-08-22 03:49:12 UTC) #3
commit-bot: I haz the power
Change committed as 218945
7 years, 4 months ago (2013-08-22 08:05:55 UTC) #4
Mr4D (OOO till 08-26)
7 years, 4 months ago (2013-08-22 14:04:39 UTC) #5
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698