chrome/browser/signin/profile_oauth2_token_service.cc - Issue 23068005: Convert UserPolicySigninService to use OAuth2TokenService

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/signin/profile_oauth2_token_service.cc

Issue 23068005: Convert UserPolicySigninService to use OAuth2TokenService (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Addressed code review feedback. Created 7 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/signin/profile_oauth2_token_service.cc

diff --git a/chrome/browser/signin/profile_oauth2_token_service.cc b/chrome/browser/signin/profile_oauth2_token_service.cc

index 6c00938c6acde13cdb628931cba2d4e0ba0954c3..e280413c2eab001620cbf93d43eea7ec02741f17 100644

--- a/chrome/browser/signin/profile_oauth2_token_service.cc

+++ b/chrome/browser/signin/profile_oauth2_token_service.cc

@@ -68,8 +68,6 @@ ProfileOAuth2TokenService::~ProfileOAuth2TokenService() {

}

void ProfileOAuth2TokenService::Initialize(Profile* profile) {

- DCHECK(content::BrowserThread::CurrentlyOn(content::BrowserThread::UI));

DCHECK(profile);

DCHECK(!profile_);

profile_ = profile;

@@ -93,6 +91,7 @@ void ProfileOAuth2TokenService::Initialize(Profile* profile) {

}

void ProfileOAuth2TokenService::Shutdown() {

+ DCHECK(profile_) << "Shutdown() called without matching call to Initialize()";

CancelAllRequests();

signin_global_error_->RemoveProvider(this);

GlobalErrorServiceFactory::GetForProfile(profile_)->RemoveGlobalError(