Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2114)

Unified Diff: chrome/browser/policy/cloud/user_policy_signin_service_base.cc

Issue 23068005: Convert UserPolicySigninService to use OAuth2TokenService (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Addressed code review feedback. Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/policy/cloud/user_policy_signin_service_base.cc
diff --git a/chrome/browser/policy/cloud/user_policy_signin_service_base.cc b/chrome/browser/policy/cloud/user_policy_signin_service_base.cc
index d50902ec6c83f497fd86330fd241741ae53bfb1c..ae1d7bdfa080f684d0479f21f1537f69412f363e 100644
--- a/chrome/browser/policy/cloud/user_policy_signin_service_base.cc
+++ b/chrome/browser/policy/cloud/user_policy_signin_service_base.cc
@@ -133,6 +133,10 @@ void UserPolicySigninServiceBase::OnClientError(CloudPolicyClient* client) {
}
void UserPolicySigninServiceBase::Shutdown() {
+ PrepareForUserCloudPolicyManagerShutdown();
+}
+
+void UserPolicySigninServiceBase::PrepareForUserCloudPolicyManagerShutdown() {
UserCloudPolicyManager* manager = GetManager();
if (manager && manager->core()->client())
manager->core()->client()->RemoveObserver(this);
@@ -230,7 +234,7 @@ void UserPolicySigninServiceBase::InitializeUserCloudPolicyManager(
}
void UserPolicySigninServiceBase::ShutdownUserCloudPolicyManager() {
- Shutdown();
+ PrepareForUserCloudPolicyManagerShutdown();
UserCloudPolicyManager* manager = GetManager();
if (manager)
manager->DisconnectAndRemovePolicy();

Powered by Google App Engine
This is Rietveld 408576698