components/browser_context_keyed_service/browser_context_dependency_manager.cc - Issue 23068005: Convert UserPolicySigninService to use OAuth2TokenService

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/browser_context_keyed_service/browser_context_dependency_manager.cc

Issue 23068005: Convert UserPolicySigninService to use OAuth2TokenService (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 7 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/extensions/menu_manager_unittest.cc ('K') | « components/autofill/core/browser/personal_data_manager_unittest.cc ('k') | components/browser_context_keyed_service/browser_context_keyed_base_factory.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/browser_context_keyed_service/browser_context_dependency_manager.cc

diff --git a/components/browser_context_keyed_service/browser_context_dependency_manager.cc b/components/browser_context_keyed_service/browser_context_dependency_manager.cc

index 1031f4e831026d376c47f35bac56e52cd304d636..4b4fc682502722a567732e53291063b265e04d9a 100644

--- a/components/browser_context_keyed_service/browser_context_dependency_manager.cc

+++ b/components/browser_context_keyed_service/browser_context_dependency_manager.cc

@@ -64,9 +64,11 @@ void BrowserContextDependencyManager::CreateBrowserContextServices(

BrowserContextKeyedBaseFactory* factory =

static_cast<BrowserContextKeyedBaseFactory*>(construction_order[i]);

- if (!context->IsOffTheRecord()) {

+ if (is_testing_context || !context->IsOffTheRecord()) {

// We only register preferences on normal contexts because the incognito

- // context shares the pref service with the normal one.

+ // context shares the pref service with the normal one. Always register

+ // for testing contexts, because they often are created standalone

+ // without an associated "normal" context.

factory->RegisterUserPrefsOnBrowserContext(context);

}