Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(499)

Unified Diff: components/sync/protocol/proto_value_conversions_unittest.cc

Issue 2306763002: Add PrinterSpecifics to the sync protos. (Closed)
Patch Set: add comments to proto Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/sync/protocol/proto_value_conversions_unittest.cc
diff --git a/components/sync/protocol/proto_value_conversions_unittest.cc b/components/sync/protocol/proto_value_conversions_unittest.cc
index 3d4d5704ffaf93b3075304bbc3ff68c4345caf0d..b01f8e565d1cfb2a4cb20737828713fb969cf5f6 100644
--- a/components/sync/protocol/proto_value_conversions_unittest.cc
+++ b/components/sync/protocol/proto_value_conversions_unittest.cc
@@ -60,7 +60,7 @@ TEST_F(ProtoValueConversionsTest, ProtoChangeCheck) {
// If this number changes, that means we added or removed a data
// type. Don't forget to add a unit test for {New
// type}SpecificsToValue below.
- EXPECT_EQ(37, MODEL_TYPE_COUNT);
+ EXPECT_EQ(38, MODEL_TYPE_COUNT);
// We'd also like to check if we changed any field in our messages.
// However, that's hard to do: sizeof could work, but it's
@@ -258,6 +258,10 @@ TEST_F(ProtoValueConversionsTest, PreferenceSpecificsToValue) {
TestSpecificsToValue(PreferenceSpecificsToValue);
}
+TEST_F(ProtoValueConversionsTest, PrintersSpecificsToValue) {
+ TestSpecificsToValue(PrintersSpecificsToValue);
+}
+
TEST_F(ProtoValueConversionsTest, SearchEngineSpecificsToValue) {
TestSpecificsToValue(SearchEngineSpecificsToValue);
}
@@ -326,6 +330,7 @@ TEST_F(ProtoValueConversionsTest, EntitySpecificsToValue) {
SET_FIELD(nigori);
SET_FIELD(password);
SET_FIELD(preference);
+ SET_FIELD(printers);
SET_FIELD(priority_preference);
SET_FIELD(search_engine);
SET_FIELD(session);

Powered by Google App Engine
This is Rietveld 408576698