Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(194)

Issue 2306743002: Nukes the gyp/gypi files in ui (Closed)

Created:
4 years, 3 months ago by sky
Modified:
4 years, 3 months ago
Reviewers:
sadrul, Dan Beam
CC:
chromium-reviews, sadrul, yusukes+watch_chromium.org, alemate+watch_chromium.org, posciak+watch_chromium.org, nektar+watch_chromium.org, hidehiko+watch_chromium.org, fukino+watch_chromium.org, sievers+watch_chromium.org, rginda+watch_chromium.org, mtomasz+watch_chromium.org, lhchavez+watch_chromium.org, dmazzoni+watch_chromium.org, vitalyp+closure_chromium.org, extensions-reviews_chromium.org, Matt Giuca, aboxhall+watch_chromium.org, mlamouri+watch-notifications_chromium.org, achuith+watch_chromium.org, jbauman+watch_chromium.org, nona+watch_chromium.org, je_julie, dbeam+watch-elements_chromium.org, kalyank, michaelpg+watch-elements_chromium.org, ozone-reviews_chromium.org, dbeam+watch-closure_chromium.org, oka+watch_chromium.org, derat+watch_chromium.org, tdresser+watch_chromium.org, Peter Beverloo, yamaguchi+watch_chromium.org, yuzo+watch_chromium.org, oshima+watch_chromium.org, chromium-apps-reviews_chromium.org, piman+watch_chromium.org, cc-bugs_chromium.org, elijahtaylor+arcwatch_chromium.org, Ian Vollick, tfarina, shuchen+watch_chromium.org, dtapuska+chromiumwatch_chromium.org, jlklein+watch-closure_chromium.org, dtseng+watch_chromium.org, danakj+watch_chromium.org, James Su, stevenjb+watch-md-settings_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Nukes the gyp/gypi files in ui They aren't needed or used anymore. BUG=none TEST=none R=sadrul@chromium.org Committed: https://crrev.com/a6e3f1110438f6eaf66e0caa1d9f18e22b43449f Cr-Commit-Position: refs/heads/master@{#416121}

Patch Set 1 #

Patch Set 2 : keep webui #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -11534 lines) Patch
D ui/accelerated_widget_mac/accelerated_widget_mac.gyp View 1 chunk +0 lines, -78 lines 0 comments Download
D ui/accessibility/accessibility.gyp View 1 chunk +0 lines, -229 lines 0 comments Download
D ui/accessibility/extensions/accessibility_extensions.gyp View 1 chunk +0 lines, -247 lines 0 comments Download
D ui/android/ui_android.gyp View 1 chunk +0 lines, -250 lines 0 comments Download
D ui/app_list/app_list.gyp View 1 chunk +0 lines, -334 lines 0 comments Download
D ui/app_list/presenter/app_list_presenter.gyp View 1 chunk +0 lines, -122 lines 0 comments Download
D ui/app_list/resources/app_list_resources.gyp View 1 chunk +0 lines, -27 lines 0 comments Download
D ui/arc/arc.gyp View 1 chunk +0 lines, -75 lines 0 comments Download
D ui/aura/aura.gyp View 1 chunk +0 lines, -318 lines 0 comments Download
D ui/aura_extra/aura_extra.gyp View 1 chunk +0 lines, -34 lines 0 comments Download
D ui/base/ime/ui_base_ime.gyp View 1 chunk +0 lines, -202 lines 0 comments Download
D ui/base/ui_base.gyp View 1 chunk +0 lines, -784 lines 0 comments Download
D ui/base/ui_base_tests.gyp View 1 chunk +0 lines, -335 lines 0 comments Download
D ui/base/ui_base_tests_bundle.gypi View 1 chunk +0 lines, -55 lines 0 comments Download
D ui/base/x/ui_base_x.gyp View 1 chunk +0 lines, -49 lines 0 comments Download
D ui/chromeos/ui_chromeos.gyp View 1 chunk +0 lines, -139 lines 0 comments Download
D ui/compositor/compositor.gyp View 1 chunk +0 lines, -246 lines 0 comments Download
D ui/content_accelerators/ui_content_accelerators.gyp View 1 chunk +0 lines, -27 lines 0 comments Download
D ui/display/display.gyp View 1 chunk +0 lines, -294 lines 0 comments Download
D ui/events/blink/events_blink.gyp View 1 chunk +0 lines, -34 lines 0 comments Download
D ui/events/devices/events_devices.gyp View 1 chunk +0 lines, -44 lines 0 comments Download
D ui/events/devices/x11/events_devices_x11.gyp View 1 chunk +0 lines, -39 lines 0 comments Download
D ui/events/events.gyp View 1 chunk +0 lines, -394 lines 0 comments Download
D ui/events/events_unittests.gyp View 1 chunk +0 lines, -196 lines 0 comments Download
D ui/events/keycodes/events_keycodes.gyp View 1 chunk +0 lines, -54 lines 0 comments Download
D ui/events/ozone/events_ozone.gyp View 1 chunk +0 lines, -202 lines 0 comments Download
D ui/events/platform/events_platform.gyp View 1 chunk +0 lines, -36 lines 0 comments Download
D ui/events/platform/x11/x11_events_platform.gyp View 1 chunk +0 lines, -55 lines 0 comments Download
D ui/events/x/events_x.gyp View 1 chunk +0 lines, -40 lines 0 comments Download
D ui/file_manager/audio_player/elements/compiled_resources2.gyp View 1 chunk +0 lines, -23 lines 0 comments Download
D ui/file_manager/audio_player/js/compiled_resources.gyp View 1 chunk +0 lines, -114 lines 0 comments Download
D ui/file_manager/audio_player/js/compiled_resources2.gyp View 1 chunk +0 lines, -27 lines 0 comments Download
D ui/file_manager/compile_js.gypi View 1 chunk +0 lines, -12 lines 0 comments Download
D ui/file_manager/compile_js2.gypi View 1 chunk +0 lines, -12 lines 0 comments Download
D ui/file_manager/compiled_resources2.gyp View 1 chunk +0 lines, -18 lines 0 comments Download
D ui/file_manager/externs/compiled_resources2.gyp View 1 chunk +0 lines, -91 lines 0 comments Download
D ui/file_manager/file_manager.gyp View 1 chunk +0 lines, -52 lines 0 comments Download
D ui/file_manager/file_manager/background/js/compiled_resources.gyp View 1 chunk +0 lines, -72 lines 0 comments Download
D ui/file_manager/file_manager/background/js/compiled_resources2.gyp View 1 chunk +0 lines, -143 lines 0 comments Download
D ui/file_manager/file_manager/common/js/compiled_resources2.gyp View 1 chunk +0 lines, -91 lines 0 comments Download
D ui/file_manager/file_manager/foreground/elements/compiled_resources2.gyp View 1 chunk +0 lines, -51 lines 0 comments Download
D ui/file_manager/file_manager/foreground/js/compiled_resources.gyp View 1 chunk +0 lines, -194 lines 0 comments Download
D ui/file_manager/file_manager/foreground/js/compiled_resources2.gyp View 1 chunk +0 lines, -259 lines 0 comments Download
D ui/file_manager/file_manager/foreground/js/metadata/compiled_resources.gyp View 1 chunk +0 lines, -30 lines 0 comments Download
D ui/file_manager/file_manager/foreground/js/metadata/compiled_resources2.gyp View 1 chunk +0 lines, -131 lines 0 comments Download
D ui/file_manager/file_manager/foreground/js/ui/compiled_resources2.gyp View 1 chunk +0 lines, -151 lines 0 comments Download
D ui/file_manager/gallery/js/compiled_resources.gyp View 1 chunk +0 lines, -159 lines 0 comments Download
D ui/file_manager/gallery/js/compiled_resources2.gyp View 1 chunk +0 lines, -91 lines 0 comments Download
D ui/file_manager/gallery/js/image_editor/compiled_resources2.gyp View 1 chunk +0 lines, -67 lines 0 comments Download
D ui/file_manager/image_loader/compiled_resources.gyp View 1 chunk +0 lines, -34 lines 0 comments Download
D ui/file_manager/image_loader/compiled_resources2.gyp View 1 chunk +0 lines, -47 lines 0 comments Download
D ui/file_manager/video_player/js/cast/compiled_resources2.gyp View 1 chunk +0 lines, -23 lines 0 comments Download
D ui/file_manager/video_player/js/compiled_resources.gyp View 1 chunk +0 lines, -125 lines 0 comments Download
D ui/file_manager/video_player/js/compiled_resources2.gyp View 1 chunk +0 lines, -35 lines 0 comments Download
D ui/gfx/gfx.gyp View 1 chunk +0 lines, -596 lines 0 comments Download
D ui/gfx/gfx_geometry.gypi View 1 chunk +0 lines, -56 lines 0 comments Download
D ui/gfx/gfx_nacl.gyp View 1 chunk +0 lines, -40 lines 0 comments Download
D ui/gfx/gfx_tests.gyp View 1 chunk +0 lines, -207 lines 0 comments Download
D ui/gfx/ipc/color/gfx_ipc_color.gyp View 1 chunk +0 lines, -24 lines 0 comments Download
D ui/gfx/ipc/color/gfx_ipc_color.gypi View 1 chunk +0 lines, -17 lines 0 comments Download
D ui/gfx/ipc/geometry/gfx_ipc_geometry.gyp View 1 chunk +0 lines, -52 lines 0 comments Download
D ui/gfx/ipc/geometry/gfx_ipc_geometry.gypi View 1 chunk +0 lines, -17 lines 0 comments Download
D ui/gfx/ipc/geometry/gfx_ipc_geometry_nacl.gyp View 1 chunk +0 lines, -40 lines 0 comments Download
D ui/gfx/ipc/gfx_ipc.gyp View 1 chunk +0 lines, -36 lines 0 comments Download
D ui/gfx/ipc/skia/gfx_ipc_skia.gyp View 1 chunk +0 lines, -34 lines 0 comments Download
D ui/gfx/x/gfx_x11.gyp View 1 chunk +0 lines, -39 lines 0 comments Download
D ui/gl/gl.gyp View 1 chunk +0 lines, -374 lines 0 comments Download
D ui/gl/gl_tests.gyp View 1 chunk +0 lines, -138 lines 0 comments Download
D ui/gl/init/gl_init.gyp View 1 chunk +0 lines, -79 lines 0 comments Download
D ui/keyboard/keyboard.gyp View 1 chunk +0 lines, -154 lines 0 comments Download
D ui/keyboard/resources/compiled_resources.gyp View 1 chunk +0 lines, -11 lines 0 comments Download
D ui/login/login.gyp View 1 chunk +0 lines, -35 lines 0 comments Download
D ui/message_center/message_center.gyp View 1 chunk +0 lines, -275 lines 0 comments Download
D ui/native_theme/native_theme.gyp View 1 chunk +0 lines, -72 lines 0 comments Download
D ui/ozone/demo/ozone_demos.gyp View 1 chunk +0 lines, -38 lines 0 comments Download
D ui/ozone/gl/ozone_gl.gyp View 1 chunk +0 lines, -28 lines 0 comments Download
D ui/ozone/ozone.gyp View 1 chunk +0 lines, -284 lines 0 comments Download
D ui/ozone/platform/caca/caca.gypi View 1 chunk +0 lines, -53 lines 0 comments Download
D ui/ozone/platform/cast/cast.gypi View 1 chunk +0 lines, -61 lines 0 comments Download
D ui/ozone/platform/drm/gbm.gypi View 1 chunk +0 lines, -209 lines 0 comments Download
D ui/ozone/platform/headless/headless.gypi View 1 chunk +0 lines, -45 lines 0 comments Download
D ui/ozone/platform/wayland/wayland.gypi View 1 chunk +0 lines, -103 lines 0 comments Download
D ui/platform_window/android/android_window.gyp View 1 chunk +0 lines, -58 lines 0 comments Download
D ui/platform_window/platform_window.gyp View 1 chunk +0 lines, -18 lines 0 comments Download
D ui/platform_window/stub/stub_window.gyp View 1 chunk +0 lines, -25 lines 0 comments Download
D ui/platform_window/win/win_window.gyp View 1 chunk +0 lines, -27 lines 0 comments Download
D ui/platform_window/x11/x11_window.gyp View 1 chunk +0 lines, -35 lines 0 comments Download
D ui/resources/ui_resources.gyp View 1 chunk +0 lines, -151 lines 0 comments Download
D ui/shell_dialogs/shell_dialogs.gyp View 1 chunk +0 lines, -116 lines 0 comments Download
D ui/snapshot/snapshot.gyp View 1 chunk +0 lines, -97 lines 0 comments Download
D ui/strings/ui_strings.gyp View 1 chunk +0 lines, -31 lines 0 comments Download
D ui/surface/surface.gyp View 1 chunk +0 lines, -43 lines 0 comments Download
D ui/touch_selection/ui_touch_selection.gyp View 1 chunk +0 lines, -178 lines 0 comments Download
D ui/views/controls/webview/webview.gyp View 1 chunk +0 lines, -51 lines 0 comments Download
D ui/views/controls/webview/webview_tests.gyp View 1 chunk +0 lines, -45 lines 0 comments Download
D ui/views/examples/examples.gyp View 1 chunk +0 lines, -203 lines 0 comments Download
D ui/views/linux_ui/linux_ui.gyp View 1 chunk +0 lines, -33 lines 0 comments Download
D ui/views/resources/views_resources.gyp View 1 chunk +0 lines, -27 lines 0 comments Download
D ui/views_content_client/views_content_client.gyp View 1 chunk +0 lines, -63 lines 0 comments Download
D ui/web_dialogs/web_dialogs.gyp View 1 chunk +0 lines, -50 lines 0 comments Download
D ui/wm/wm.gyp View 1 chunk +0 lines, -175 lines 0 comments Download

Messages

Total messages: 21 (13 generated)
sky
4 years, 3 months ago (2016-09-01 22:05:31 UTC) #3
sky
I restored the gyp* files in webui as they appear to be used by some ...
4 years, 3 months ago (2016-09-01 22:43:41 UTC) #8
sadrul
YAY!! LGTM
4 years, 3 months ago (2016-09-01 23:07:35 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2306743002/20001
4 years, 3 months ago (2016-09-01 23:08:53 UTC) #14
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 3 months ago (2016-09-01 23:37:21 UTC) #16
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/a6e3f1110438f6eaf66e0caa1d9f18e22b43449f Cr-Commit-Position: refs/heads/master@{#416121}
4 years, 3 months ago (2016-09-01 23:38:54 UTC) #18
Dan Beam
all of the compiled_resources*.gyp files probably are used https://build.chromium.org/p/chromium.fyi/builders/Closure%20Compilation%20Linux/builds/68393
4 years, 3 months ago (2016-09-01 23:55:36 UTC) #20
sky
4 years, 3 months ago (2016-09-01 23:59:46 UTC) #21
Message was sent while issue was closed.
I went by what the PRESUBMIT check looked for, which was only webui files.

I thought gyp was dead, why is this bot still using gyp files?

  -Scott

On Thu, Sep 1, 2016 at 4:55 PM,  <dbeam@chromium.org> wrote:
> all of the compiled_resources*.gyp files probably are used
>
>
https://build.chromium.org/p/chromium.fyi/builders/Closure%20Compilation%20Li...
>
> https://codereview.chromium.org/2306743002/

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

Powered by Google App Engine
This is Rietveld 408576698