android_webview/java/src/org/chromium/android_webview/AwContentsClientCallbackHelper.java - Issue 230673004: Adds unit tests for AwContentsClientCallbackHelper

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: android_webview/java/src/org/chromium/android_webview/AwContentsClientCallbackHelper.java

Issue 230673004: Adds unit tests for AwContentsClientCallbackHelper (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fixed typos and test names Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | android_webview/javatests/src/org/chromium/android_webview/test/AwContentsClientAutoLoginTest.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: android_webview/java/src/org/chromium/android_webview/AwContentsClientCallbackHelper.java

diff --git a/android_webview/java/src/org/chromium/android_webview/AwContentsClientCallbackHelper.java b/android_webview/java/src/org/chromium/android_webview/AwContentsClientCallbackHelper.java

index 291b251eafb8c2419697c544311a8ed6635b5758..f926bb87c1c47384acc7f361b0b71094429516e8 100644

--- a/android_webview/java/src/org/chromium/android_webview/AwContentsClientCallbackHelper.java

+++ b/android_webview/java/src/org/chromium/android_webview/AwContentsClientCallbackHelper.java

@@ -10,6 +10,8 @@ import android.os.Looper;

import android.os.Message;

import android.os.SystemClock;

+import com.google.common.annotations.VisibleForTesting;

import java.util.concurrent.Callable;

/**

@@ -18,7 +20,8 @@ import java.util.concurrent.Callable;

* Most callbacks do no go through here, but get forwarded to AwContentsClient directly. The

* messages processed here may originate from the IO or UI thread.

-class AwContentsClientCallbackHelper {

+@VisibleForTesting

+public class AwContentsClientCallbackHelper {

// TODO(boliu): Consider removing DownloadInfo and LoginRequestInfo by using native

// MessageLoop to post directly to AwContents.

« no previous file with comments | « no previous file | android_webview/javatests/src/org/chromium/android_webview/test/AwContentsClientAutoLoginTest.java » ('j') | no next file with comments »