Issue 23067008: Add warning to cctest when running multiple tests in sequence.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 23067008: Add warning to cctest when running multiple tests in sequence. (Closed)

Created:
7 years, 4 months ago by Yang

Modified:
7 years, 4 months ago

Reviewers:
Michael Starzinger

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Add warning to cctest when running multiple tests in sequence. R=mstarzinger@chromium.org BUG=v8:2848 Committed: https://code.google.com/p/v8/source/detail?r=16247

Patch Set 2 : addressed comment. #

Created: 7 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -2 lines)			Patch
	M	test/cctest/cctest.cc	View	1	3 chunks	+9 lines, -2 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Michael Starzinger

LGTM with a nit. https://codereview.chromium.org/23067008/diff/1/test/cctest/cctest.cc File test/cctest/cctest.cc (right): https://codereview.chromium.org/23067008/diff/1/test/cctest/cctest.cc#newcode109 test/cctest/cctest.cc:109: void SuggestTestHarness(int tests) { nit: ...

7 years, 4 months ago (2013-08-20 12:16:11 UTC) #2

Message was sent while issue was closed.

Committed patchset #2 manually as r16247.

Expand Messages | Collapse Messages

Issue 23067008: Add warning to cctest when running multiple tests in sequence. (Closed)

Description

Patch Set 1 #

Patch Set 2 : addressed comment. #

Messages