Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3591)

Unified Diff: chrome/browser/ui/views/website_settings/permission_selector_row.h

Issue 2306673003: Material Page Info (Views, 3/3): Update site settings section. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Pointers. Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/website_settings/permission_selector_row.h
diff --git a/chrome/browser/ui/views/website_settings/permission_selector_row.h b/chrome/browser/ui/views/website_settings/permission_selector_row.h
index 78d24fc3fcbe24100ff9ea75e8f22c6327c1cc7e..a267a720f702102766dfe5b183b5c6dffddae0a5 100644
--- a/chrome/browser/ui/views/website_settings/permission_selector_row.h
+++ b/chrome/browser/ui/views/website_settings/permission_selector_row.h
@@ -17,6 +17,7 @@
#include "components/content_settings/core/common/content_settings.h"
#include "components/content_settings/core/common/content_settings_types.h"
#include "ui/views/controls/button/menu_button_listener.h"
+#include "ui/views/layout/grid_layout.h"
#include "ui/views/view.h"
namespace internal {
@@ -34,21 +35,21 @@ class MenuRunner;
// A PermissionSelectorRow is a row in the Page Info bubble that shows a
// permission that a site can have ambient access to, and allows the user to
// control whether that access is granted.
-class PermissionSelectorRow : public views::View {
+class PermissionSelectorRow {
public:
+ // The constructor adds two views to the current row of |layout|:
+ // 1. An icon.
+ // 2. A view with a left-aligned label and a right-aligned menu.
PermissionSelectorRow(const GURL& url,
- const WebsiteSettingsUI::PermissionInfo& permission);
+ const WebsiteSettingsUI::PermissionInfo& permission,
+ views::GridLayout* layout);
void AddObserver(PermissionSelectorRowObserver* observer);
void PermissionChanged(const WebsiteSettingsUI::PermissionInfo& permission);
- protected:
- // Overridden from views::View.
- void ChildPreferredSizeChanged(View* child) override;
-
private:
- ~PermissionSelectorRow() override;
+ ~PermissionSelectorRow();
void InitializeMenuButtonView(
views::GridLayout* layout,

Powered by Google App Engine
This is Rietveld 408576698