Add observer for BAAnnots from Javascript

fpdfsdk/javascript/Annot.h

Index: fpdfsdk/javascript/Annot.h
diff --git a/fpdfsdk/javascript/Annot.h b/fpdfsdk/javascript/Annot.h
index b3ea292aed86e3a30e6912058477e3bed590b31c..97d0a2fd13c54ed869a5da13676a4bb1fd9e71ad 100644
--- a/fpdfsdk/javascript/Annot.h
+++ b/fpdfsdk/javascript/Annot.h
@@ -7,6 +7,8 @@
 #ifndef FPDFSDK_JAVASCRIPT_ANNOT_H_
 #define FPDFSDK_JAVASCRIPT_ANNOT_H_
 
+#include <memory>
+
 #include "fpdfsdk/include/cpdfsdk_baannot.h"
 #include "fpdfsdk/javascript/JS_Define.h"
 
@@ -22,7 +24,8 @@ class Annot : public CJS_EmbedObj {
   void SetSDKAnnot(CPDFSDK_BAAnnot* annot);
 
  private:
-  CPDFSDK_BAAnnot* m_BAAnnot = nullptr;
+  CPDFSDK_Annot* m_Annot = nullptr;

[Lei Zhang, 2016/09/02 01:21:25]

Can this stay as a CPDFSDK_BAAnnot*, and thus remove the need for ToBAAnnot() ?

[Lei Zhang, 2016/09/02 01:21:25]

nit: m_pAnnot

[dsinclair, 2016/09/06 15:44:49]

Sigh, can we start moving away from this notation soon?

[dsinclair, 2016/09/06 15:44:49]

No, this has to be a CPDFSDK_Annot so we can pass the pointer to the pointer
into the observer.

+  std::unique_ptr<CPDFSDK_Annot::Observer> m_pObserver;
 };
 
 class CJS_Annot : public CJS_Object {