Add observer for BAAnnots from Javascript

fpdfsdk/javascript/Annot.h

 // Copyright 2016 PDFium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
 
 #ifndef FPDFSDK_JAVASCRIPT_ANNOT_H_
 #define FPDFSDK_JAVASCRIPT_ANNOT_H_
 
+#include <memory>
+
 #include "fpdfsdk/include/cpdfsdk_baannot.h"
 #include "fpdfsdk/javascript/JS_Define.h"
 
 class Annot : public CJS_EmbedObj {
  public:
   explicit Annot(CJS_Object* pJSObject);
   ~Annot() override;
 
   FX_BOOL hidden(IJS_Context* cc, CJS_PropValue& vp, CFX_WideString& sError);
   FX_BOOL name(IJS_Context* cc, CJS_PropValue& vp, CFX_WideString& sError);
   FX_BOOL type(IJS_Context* cc, CJS_PropValue& vp, CFX_WideString& sError);
 
   void SetSDKAnnot(CPDFSDK_BAAnnot* annot);
 
  private:
-  CPDFSDK_BAAnnot* m_BAAnnot = nullptr;
+  CPDFSDK_Annot* m_Annot = nullptr;

[Lei Zhang, 2016/09/02 01:21:25]

Can this stay as a CPDFSDK_BAAnnot*, and thus remove the need for ToBAAnnot() ?

[Lei Zhang, 2016/09/02 01:21:25]

nit: m_pAnnot

[dsinclair, 2016/09/06 15:44:49]

Sigh, can we start moving away from this notation soon?

[dsinclair, 2016/09/06 15:44:49]

No, this has to be a CPDFSDK_Annot so we can pass the pointer to the pointer
into the observer.

+  std::unique_ptr<CPDFSDK_Annot::Observer> m_pObserver;
 };
 
 class CJS_Annot : public CJS_Object {
  public:
   explicit CJS_Annot(v8::Local<v8::Object> pObject) : CJS_Object(pObject) {}
   ~CJS_Annot() override {}
 
   DECLARE_JS_CLASS();
   JS_STATIC_PROP(hidden, Annot);
   JS_STATIC_PROP(name, Annot);
   JS_STATIC_PROP(type, Annot);
 };
 
 #endif  // FPDFSDK_JAVASCRIPT_ANNOT_H_