Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(479)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2306643003: WebRange-ify WebWidget::compositionRange. (Closed)

Created:
4 years, 3 months ago by dglazkov
Modified:
4 years, 3 months ago
Reviewers:
esprehn
CC:
blink-reviews, blink-reviews-api_chromium.org, chromium-reviews, darin-cc_chromium.org, dcheng, dglazkov+blink, jam, kinuko+watch, mlamouri+watch-content_chromium.org, mlamouri+watch-blink_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

WebRange-ify WebWidget::compositionRange. No functional change, just turning one last pair of ints into a WebRange. R=esprehn BUG= Committed: https://crrev.com/78a24b64c6c0cb9b2ba17c5f7f6386de8efe77ef Cr-Commit-Position: refs/heads/master@{#416350}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -39 lines) Patch
M content/renderer/render_widget.cc View 1 chunk +5 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/web/WebFrameWidgetImpl.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/WebFrameWidgetImpl.cpp View 4 chunks +10 lines, -13 lines 0 comments Download
M third_party/WebKit/Source/web/WebViewFrameWidget.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/WebViewFrameWidget.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/web/WebViewImpl.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/WebViewImpl.cpp View 3 chunks +9 lines, -13 lines 1 comment Download
M third_party/WebKit/public/web/WebWidget.h View 1 chunk +2 lines, -3 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
dglazkov
PTAL
4 years, 3 months ago (2016-09-02 15:22:29 UTC) #5
esprehn
lgtm https://codereview.chromium.org/2306643003/diff/1/third_party/WebKit/Source/web/WebViewImpl.cpp File third_party/WebKit/Source/web/WebViewImpl.cpp (right): https://codereview.chromium.org/2306643003/diff/1/third_party/WebKit/Source/web/WebViewImpl.cpp#newcode2814 third_party/WebKit/Source/web/WebViewImpl.cpp:2814: if (range.length() == 0) isEmpty() would be idiomatic.
4 years, 3 months ago (2016-09-02 21:24:34 UTC) #6
dglazkov
On 2016/09/02 at 21:24:34, esprehn wrote: > lgtm > > https://codereview.chromium.org/2306643003/diff/1/third_party/WebKit/Source/web/WebViewImpl.cpp > File third_party/WebKit/Source/web/WebViewImpl.cpp (right): ...
4 years, 3 months ago (2016-09-02 21:28:44 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2306643003/1
4 years, 3 months ago (2016-09-02 21:29:18 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-02 21:35:10 UTC) #10
commit-bot: I haz the power
4 years, 3 months ago (2016-09-02 21:38:28 UTC) #12
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/78a24b64c6c0cb9b2ba17c5f7f6386de8efe77ef
Cr-Commit-Position: refs/heads/master@{#416350}

Powered by Google App Engine
This is Rietveld 408576698