Issue 230663004: Fix WebKeyboardEvent interruption of compositor scrolling

Issue 230663004: Fix WebKeyboardEvent interruption of compositor scrolling (Closed)

Created:
6 years, 8 months ago by jdduke (slow)

Modified:
6 years, 8 months ago

Reviewers:
dgozman, tdresser

CC:
chromium-reviews, darin-cc_chromium.org, jam, dgozman

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Visibility:
Public.

Fix WebKeyboardEvent interruption of compositor scrolling Fix an issue where keyboard events improperly reset the scroll status while a touch scroll was active in InputHandlerProxy. BUG=361160 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=262985

Created: 6 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+57 lines, -1 line)			Patch
	M	content/renderer/input/input_handler_proxy.cc	View	1 2 3	1 chunk	+4 lines, -1 line	0 comments	Download
	M	content/renderer/input/input_handler_proxy_unittest.cc	View	1 2 3	2 chunks	+53 lines, -0 lines	0 comments	Download

Total messages: 6 (0 generated)

jdduke (slow)

tdresser@: PTAL. Turns out, the change to the fling bookkeeping in GestureEventQueue was unnecessary; it's ...

6 years, 8 months ago (2014-04-09 21:40:33 UTC) #1

dgozman

I tested this patch locally with touch emulator, and it definitely fixes the DCHECK triggering ...

6 years, 8 months ago (2014-04-10 09:40:31 UTC) #2

tdresser

content/renderer/input/* LGTM. If you think the other changes are a worthwhile refactor independent of this ...

6 years, 8 months ago (2014-04-10 12:58:52 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jdduke@chromium.org/230663004/100001

6 years, 8 months ago (2014-04-10 12:59:55 UTC) #5

Message was sent while issue was closed.

Change committed as 262985