preserve GN_Android in compile -> test mapper

preserve GN_Android in compile -> test mapper

doesn't seem anything tests this?

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2306603002

Committed: https://skia.googlesource.com/skia/+/2b44853c53f4793743b8c8cfdf013dc6c0e1dc99

[mtklein_C, 2016-09-01 14:50:58]

Description was changed from

==========
preserve GN_Android in compile -> test mapper

doesn't seem anything tests this?

BUG=skia:
==========

to

==========
preserve GN_Android in compile -> test mapper

doesn't seem anything tests this?

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2306603002
==========

[mtklein_C, 2016-09-01 15:02:19]

mtklein@chromium.org changed reviewers:
+ borenet@google.com

[mtklein_C, 2016-09-01 15:02:20]

This appears to be using the GN android builder.  It'll still fail when it gets
to running.

[borenet, 2016-09-01 15:06:10]

LGTM with nit.

https://codereview.chromium.org/2306603002/diff/1/infra/bots/recipes/swarm_tr...
File infra/bots/recipes/swarm_trigger.py (right):

https://codereview.chromium.org/2306603002/diff/1/infra/bots/recipes/swarm_tr...
infra/bots/recipes/swarm_trigger.py:78: elif extra_config != 'GN_Android':
Nit: add "extra_config == 'GN_Android'" case with just "pass"? That should
enforce that we have test coverage for that case.

[mtklein_C, 2016-09-01 15:21:12]

On 2016/09/01 at 15:06:10, borenet wrote:
> LGTM with nit.
> 
>
https://codereview.chromium.org/2306603002/diff/1/infra/bots/recipes/swarm_tr...
> File infra/bots/recipes/swarm_trigger.py (right):
> 
>
https://codereview.chromium.org/2306603002/diff/1/infra/bots/recipes/swarm_tr...
> infra/bots/recipes/swarm_trigger.py:78: elif extra_config != 'GN_Android':
> Nit: add "extra_config == 'GN_Android'" case with just "pass"? That should
enforce that we have test coverage for that case.

Ah, good idea!  Done.

[borenet, 2016-09-01 15:22:45]

LGTM, builder name looks right!

[mtklein_C, 2016-09-01 15:24:44]

The CQ bit was checked by mtklein@chromium.org

[commit-bot: I haz the power, 2016-09-01 15:24:46]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-01 15:47:27]

Description was changed from

==========
preserve GN_Android in compile -> test mapper

doesn't seem anything tests this?

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2306603002
==========

to

==========
preserve GN_Android in compile -> test mapper

doesn't seem anything tests this?

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2306603002

Committed:
https://skia.googlesource.com/skia/+/2b44853c53f4793743b8c8cfdf013dc6c0e1dc99
==========

[commit-bot: I haz the power, 2016-09-01 15:47:28]

Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/2b44853c53f4793743b8c8cfdf013dc6c0e1dc99