Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(458)

Issue 2306563002: Update user agent version for iOS10. (Closed)

Created:
4 years, 3 months ago by justincohen
Modified:
4 years, 3 months ago
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update user agent version for iOS10. BUG=637385 Committed: https://crrev.com/b307c2704c871e64c0d2ed2f9457ab12f263e2e7 Cr-Commit-Position: refs/heads/master@{#417312}

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M ios/web/public/user_agent.mm View 1 chunk +1 line, -0 lines 2 comments Download

Messages

Total messages: 8 (3 generated)
justincohen
I'll double check these numbers when GM comes out, and land next week. PTAL! https://codereview.chromium.org/2306563002/diff/1/ios/web/public/user_agent.mm ...
4 years, 3 months ago (2016-09-01 11:53:55 UTC) #2
Eugene But (OOO till 7-30)
lgtm https://codereview.chromium.org/2306563002/diff/1/ios/web/public/user_agent.mm File ios/web/public/user_agent.mm (right): https://codereview.chromium.org/2306563002/diff/1/ios/web/public/user_agent.mm#newcode35 ios/web/public/user_agent.mm:35: // The WebKit version can be extracted dynamically ...
4 years, 3 months ago (2016-09-01 15:56:55 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2306563002/1
4 years, 3 months ago (2016-09-08 15:46:38 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-08 16:44:03 UTC) #6
commit-bot: I haz the power
4 years, 3 months ago (2016-09-08 16:45:44 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b307c2704c871e64c0d2ed2f9457ab12f263e2e7
Cr-Commit-Position: refs/heads/master@{#417312}

Powered by Google App Engine
This is Rietveld 408576698