[Sync] Split fake ModelTypeService impl out of SMTP tests.

[Sync] Split fake ModelTypeService impl out of SMTP tests.

This class and logic can be re-used for integration testing, so I'm
spliting it out into its own file. As a happy side-effect, this
massively reduces the size of the SMTP test file.

- Current FakeModelTypeService is renamed StubModelTypeService (does
  nothing; just compiles).
- SMTP test impl is moved into FakeModelTypeService (fully functional
  key/value service using PREFERENCES specifics and an in-memory store.)
- Updated some loops to use const auto &kv.

BUG=643269
Committed: https://crrev.com/2824d17cd962de7d41bd00ff0318fe44ff4e2871
Cr-Commit-Position: refs/heads/master@{#416691}

[maxbogue, 2016-09-01 18:48:48]

The CQ bit was checked by maxbogue@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-01 18:49:24]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-01 20:01:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-01 20:01:10]

Dry run: This issue passed the CQ dry run.

[maxbogue, 2016-09-01 20:11:38]

maxbogue@chromium.org changed reviewers:
+ pavely@chromium.org

[maxbogue, 2016-09-01 20:11:39]

Hey Pavel, PTAL!

[pavely, 2016-09-06 15:04:32]

lgtm

https://codereview.chromium.org/2306523003/diff/1/components/sync/api/fake_mo...
File components/sync/api/fake_model_type_service.h (right):

https://codereview.chromium.org/2306523003/diff/1/components/sync/api/fake_mo...
components/sync/api/fake_model_type_service.h:20: // A basic, functional
implementation of ModelTypeService testing purposes. It
"testing purposes" => "for testing purposes"

[maxbogue, 2016-09-06 18:42:33]

The CQ bit was checked by maxbogue@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-06 18:43:21]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[maxbogue, 2016-09-06 18:44:01]

Thanks Pavel!

https://codereview.chromium.org/2306523003/diff/1/components/sync/api/fake_mo...
File components/sync/api/fake_model_type_service.h (right):

https://codereview.chromium.org/2306523003/diff/1/components/sync/api/fake_mo...
components/sync/api/fake_model_type_service.h:20: // A basic, functional
implementation of ModelTypeService testing purposes. It
On 2016/09/06 15:04:31, pavely wrote:
> "testing purposes" => "for testing purposes"

Done.

[maxbogue, 2016-09-06 18:44:06]

The CQ bit was unchecked by maxbogue@chromium.org

[maxbogue, 2016-09-06 18:44:12]

The CQ bit was checked by maxbogue@chromium.org

[maxbogue, 2016-09-06 18:44:12]

The patchset sent to the CQ was uploaded after l-g-t-m from pavely@chromium.org
Link to the patchset: https://codereview.chromium.org/2306523003/#ps10001
(title: "Rebase + fix typo in comment.")

[commit-bot: I haz the power, 2016-09-06 18:44:27]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-06 20:17:18]

Committed patchset #2 (id:10001)

[commit-bot: I haz the power, 2016-09-06 20:19:38]

Description was changed from

==========
[Sync] Split fake ModelTypeService impl out of SMTP tests.

This class and logic can be re-used for integration testing, so I'm
spliting it out into its own file. As a happy side-effect, this
massively reduces the size of the SMTP test file.

- Current FakeModelTypeService is renamed StubModelTypeService (does
  nothing; just compiles).
- SMTP test impl is moved into FakeModelTypeService (fully functional
  key/value service using PREFERENCES specifics and an in-memory store.)
- Updated some loops to use const auto &kv.

BUG=643269
==========

to

==========
[Sync] Split fake ModelTypeService impl out of SMTP tests.

This class and logic can be re-used for integration testing, so I'm
spliting it out into its own file. As a happy side-effect, this
massively reduces the size of the SMTP test file.

- Current FakeModelTypeService is renamed StubModelTypeService (does
  nothing; just compiles).
- SMTP test impl is moved into FakeModelTypeService (fully functional
  key/value service using PREFERENCES specifics and an in-memory store.)
- Updated some loops to use const auto &kv.

BUG=643269

Committed: https://crrev.com/2824d17cd962de7d41bd00ff0318fe44ff4e2871
Cr-Commit-Position: refs/heads/master@{#416691}
==========

[commit-bot: I haz the power, 2016-09-06 20:19:40]

Patchset 2 (id:??) landed as
https://crrev.com/2824d17cd962de7d41bd00ff0318fe44ff4e2871
Cr-Commit-Position: refs/heads/master@{#416691}