Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(119)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: scripts/slave/recipe_modules/chromium/api.py

Issue 2306523002: Avoid to use environment. (Closed)
Patch Set: rebase Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « scripts/slave/goma_utils.py ('k') | scripts/slave/recipe_modules/chromium/example.expected/basic_out_dir.json » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: scripts/slave/recipe_modules/chromium/api.py
diff --git a/scripts/slave/recipe_modules/chromium/api.py b/scripts/slave/recipe_modules/chromium/api.py
index 4bf16fcb1ff5d4fe022ec137d34b3812effcc745..56759ccd142e979005fce95c549c6466bbe5db0f 100644
--- a/scripts/slave/recipe_modules/chromium/api.py
+++ b/scripts/slave/recipe_modules/chromium/api.py
@@ -177,6 +177,13 @@ class ChromiumApi(recipe_api.RecipeApi):
'--goma-cache-dir', self.m.path['goma_cache'],
]
+ # Set some buildbot info used in goma_utils.
+ for key in ['buildername', 'mastername', 'slavename', 'clobber']:
+ if key in self.m.properties:
+ args.extend([
+ '--buildbot-%s' % key, self.m.properties[key]
+ ])
+
# Use explicit goma deps cache dir if it's set in the path config.
# Otherwise use the default one inside build output directory.
try:
« no previous file with comments | « scripts/slave/goma_utils.py ('k') | scripts/slave/recipe_modules/chromium/example.expected/basic_out_dir.json » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698