scripts/slave/recipes/closure_compilation.expected/closure_compilation_fyi.json - Issue 2306523002: Avoid to use environment.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: scripts/slave/recipes/closure_compilation.expected/closure_compilation_fyi.json

Issue 2306523002: Avoid to use environment. (Closed)

Patch Set: rebase Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « scripts/slave/recipes/chromium_trybot.expected/webkit_tests_with_and_without_patch_fail.json ('k') | scripts/slave/recipes/closure_compilation.expected/closure_compilation_try.json » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 [	1 [

2 {	2 {

3 "cmd": [	3 "cmd": [

4 "python",	4 "python",

5 "-u",	5 "-u",

6 "RECIPE_MODULE[depot_tools::bot_update]/resources/bot_update.py",	6 "RECIPE_MODULE[depot_tools::bot_update]/resources/bot_update.py",

7 "--master",	7 "--master",

8 "chromium.fyi",	8 "chromium.fyi",

9 "--builder",	9 "--builder",

10 "Closure Compilation Linux",	10 "Closure Compilation Linux",

(...skipping 119 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
130 "--gsutil-py-path",	130 "--gsutil-py-path",

131 "RECIPE_PACKAGE_REPO[depot_tools]/gsutil.py",	131 "RECIPE_PACKAGE_REPO[depot_tools]/gsutil.py",

132 "--ninja-path",	132 "--ninja-path",

133 "RECIPE_PACKAGE_REPO[depot_tools]/ninja",	133 "RECIPE_PACKAGE_REPO[depot_tools]/ninja",

134 "--target",	134 "--target",

135 "Release",	135 "Release",

136 "--src-dir",	136 "--src-dir",

137 "[SLAVE_BUILD]/src",	137 "[SLAVE_BUILD]/src",

138 "--goma-cache-dir",	138 "--goma-cache-dir",

139 "[GOMA_CACHE]",	139 "[GOMA_CACHE]",

	140 "--buildbot-buildername",

	141 "Closure Compilation Linux",

	142 "--buildbot-mastername",

	143 "chromium.fyi",

	144 "--buildbot-slavename",

	145 "TestSlavename",

140 "--"	146 "--"

141 ],	147 ],

142 "env": {	148 "env": {

143 "GOMA_SERVICE_ACCOUNT_JSON_FILE": "/creds/service_accounts/service-account -goma-client.json"	149 "GOMA_SERVICE_ACCOUNT_JSON_FILE": "/creds/service_accounts/service-account -goma-client.json"

144 },	150 },

145 "name": "compile"	151 "name": "compile"

146 },	152 },

147 {	153 {

148 "cmd": [	154 "cmd": [

149 "[SLAVE_BUILD]/src/build/gyp_chromium",	155 "[SLAVE_BUILD]/src/build/gyp_chromium",

(...skipping 12 matching lines...) Expand all Loading...
162 "--gsutil-py-path",	168 "--gsutil-py-path",

163 "RECIPE_PACKAGE_REPO[depot_tools]/gsutil.py",	169 "RECIPE_PACKAGE_REPO[depot_tools]/gsutil.py",

164 "--ninja-path",	170 "--ninja-path",

165 "RECIPE_PACKAGE_REPO[depot_tools]/ninja",	171 "RECIPE_PACKAGE_REPO[depot_tools]/ninja",

166 "--target",	172 "--target",

167 "Release",	173 "Release",

168 "--src-dir",	174 "--src-dir",

169 "[SLAVE_BUILD]/src",	175 "[SLAVE_BUILD]/src",

170 "--goma-cache-dir",	176 "--goma-cache-dir",

171 "[GOMA_CACHE]",	177 "[GOMA_CACHE]",

	178 "--buildbot-buildername",

	179 "Closure Compilation Linux",

	180 "--buildbot-mastername",

	181 "chromium.fyi",

	182 "--buildbot-slavename",

	183 "TestSlavename",

172 "--"	184 "--"

173 ],	185 ],

174 "env": {	186 "env": {

175 "GOMA_SERVICE_ACCOUNT_JSON_FILE": "/creds/service_accounts/service-account -goma-client.json"	187 "GOMA_SERVICE_ACCOUNT_JSON_FILE": "/creds/service_accounts/service-account -goma-client.json"

176 },	188 },

177 "name": "compile_v2"	189 "name": "compile_v2"

178 },	190 },

179 {	191 {

180 "name": "$result",	192 "name": "$result",

181 "recipe_result": null,	193 "recipe_result": null,

182 "status_code": 0	194 "status_code": 0

183 }	195 }

184 ]	196 ]

OLD	NEW