Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(287)

Unified Diff: runtime/observatory/lib/src/elements/type_arguments_ref.dart

Issue 2306483002: Converted Observatory code-view element (Closed)
Patch Set: Fixed tables headers Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/observatory/lib/src/elements/type_arguments_ref.dart
diff --git a/runtime/observatory/lib/src/elements/class_ref.dart b/runtime/observatory/lib/src/elements/type_arguments_ref.dart
similarity index 53%
copy from runtime/observatory/lib/src/elements/class_ref.dart
copy to runtime/observatory/lib/src/elements/type_arguments_ref.dart
index 8596d73dd9290b4dcace9d2d60a41d9983679c1e..f6f004cc5276f1a02683053e2b96d00b7311a811 100644
--- a/runtime/observatory/lib/src/elements/class_ref.dart
+++ b/runtime/observatory/lib/src/elements/type_arguments_ref.dart
@@ -9,31 +9,31 @@ import 'package:observatory/src/elements/helpers/rendering_scheduler.dart';
import 'package:observatory/src/elements/helpers/tag.dart';
import 'package:observatory/src/elements/helpers/uris.dart';
-class ClassRefElement extends HtmlElement implements Renderable {
- static const tag = const Tag<ClassRefElement>('class-ref-wrapped');
+class TypeArgumentsRefElement extends HtmlElement implements Renderable {
+ static const tag = const Tag<TypeArgumentsRefElement>('type-arguments-ref');
- RenderingScheduler<ClassRefElement> _r;
+ RenderingScheduler<TypeArgumentsRefElement> _r;
- Stream<RenderedEvent<ClassRefElement>> get onRendered => _r.onRendered;
+ Stream<RenderedEvent<TypeArgumentsRefElement>> get onRendered => _r.onRendered;
M.IsolateRef _isolate;
- M.ClassRef _class;
+ M.TypeArgumentsRef _arguments;
M.IsolateRef get isolate => _isolate;
- M.ClassRef get cls => _class;
+ M.TypeArgumentsRef get arguments => _arguments;
- factory ClassRefElement(M.IsolateRef isolate, M.ClassRef cls,
+ factory TypeArgumentsRefElement(M.IsolateRef isolate, M.TypeArgumentsRef args,
{RenderingQueue queue}) {
assert(isolate != null);
- assert(cls != null);
- ClassRefElement e = document.createElement(tag.name);
+ assert(args != null);
+ TypeArgumentsRefElement e = document.createElement(tag.name);
e._r = new RenderingScheduler(e, queue: queue);
e._isolate = isolate;
- e._class = cls;
+ e._arguments = args;
return e;
}
- ClassRefElement.created() : super.created();
+ TypeArgumentsRefElement.created() : super.created();
@override
void attached() {
@@ -49,9 +49,12 @@ class ClassRefElement extends HtmlElement implements Renderable {
}
void render() {
+ final text = (_arguments.name == null || _arguments.name == '')
+ ? 'TypeArguments'
+ : _arguments.name;
children = [
- new AnchorElement(href: Uris.inspect(_isolate, object: _class))
- ..text = _class.name
+ new AnchorElement(href: Uris.inspect(_isolate, object: _arguments))
+ ..text = text
];
}
}
« no previous file with comments | « runtime/observatory/lib/src/elements/service_view.html ('k') | runtime/observatory/lib/src/models/objects/code.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698