Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4048)

Unified Diff: chrome/browser/web_bluetooth_browsertest.cc

Issue 2306473002: bluetooth: web: Update Blacklist field trial with Cypress & FIDO services. (Closed)
Patch Set: fix test Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | testing/variations/PRESUBMIT.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/web_bluetooth_browsertest.cc
diff --git a/chrome/browser/web_bluetooth_browsertest.cc b/chrome/browser/web_bluetooth_browsertest.cc
index 5bbec680d95b9770dc504bbbd709b1ddbfe0b176..a6fe14be253f949e7a57a3851f19e1d36260e81b 100644
--- a/chrome/browser/web_bluetooth_browsertest.cc
+++ b/chrome/browser/web_bluetooth_browsertest.cc
@@ -132,16 +132,15 @@ IN_PROC_BROWSER_TEST_F(WebBluetoothTest, BlacklistShouldBlock) {
EXPECT_CALL(*adapter, IsPresent()).WillRepeatedly(Return(true));
device::BluetoothAdapterFactory::SetAdapterForTesting(adapter);
- std::map<std::string, std::string> params;
- params["blacklist_additions"] = "ee01:e";
- variations::AssociateVariationParams("WebBluetoothBlacklist", "TestGroup",
- params);
- base::FieldTrialList::CreateFieldTrial("WebBluetoothBlacklist", "TestGroup");
+ ASSERT_TRUE(base::FieldTrialList::TrialExists("WebBluetoothBlacklist"))
+ << "ERROR: testing/variations/fieldtrial_testing_config_*.json must\n"
+ << "include WebBluetoothBlacklist trial with the blacklist_additions\n"
+ << "parameter including this test's random UUID 'ed5f25a4'.\n";
std::string rejection;
EXPECT_TRUE(content::ExecuteScriptAndExtractString(
web_contents_,
- "navigator.bluetooth.requestDevice({filters: [{services: [0xee01]}]})"
+ "navigator.bluetooth.requestDevice({filters: [{services: [0xed5f25a4]}]})"
" .then(() => { domAutomationController.send('Success'); },"
" reason => {"
" domAutomationController.send(reason.name + ': ' + reason.message);"
« no previous file with comments | « no previous file | testing/variations/PRESUBMIT.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698