Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(297)

Unified Diff: components/domain_reliability/BUILD.gn

Issue 2306443002: Remove GYP files from components. (Closed)
Patch Set: Remove compiled resources Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/domain_reliability.gypi ('k') | components/domain_reliability/baked_in_configs.gypi » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/domain_reliability/BUILD.gn
diff --git a/components/domain_reliability/BUILD.gn b/components/domain_reliability/BUILD.gn
index 5834a824bcb521a24eb8b6b49ee8436589c6aeaa..52620af9e656aad61abef4e57a12ce6494f56b1e 100644
--- a/components/domain_reliability/BUILD.gn
+++ b/components/domain_reliability/BUILD.gn
@@ -2,28 +2,30 @@
# Use of this source code is governed by a BSD-style license that can be
# found in the LICENSE file.
-# Paths to the JSON files are kind of gross. They're stored in the gypi
-# relative to //components, since that's the working directory gyp seems
-# to use for all of the components. When we depend on them here, we need
-# to remove the leading domain_reliability, since *our* working directory
-# is one level deeper. When we call bake_in_configs.py, we need to give
-# it a properly-rebased path to //components so it can properly join the
-# paths relative to that and find the JSON files.
-
-baked_in_configs_gypi = exec_script("//build/gypi_to_gn.py",
- [ rebase_path("baked_in_configs.gypi") ],
- "scope",
- [ "baked_in_configs.gypi" ])
-
-# The config file names in the .gypi are relative to "//components".
-baked_in_configs =
- rebase_path(baked_in_configs_gypi.baked_in_configs, ".", "//components")
-
action("bake_in_configs") {
visibility = [ ":*" ]
script = "bake_in_configs.py"
- inputs = baked_in_configs + [ "baked_in_configs.gypi" ]
+ inputs = [
+ "baked_in_configs/c_android_clients_google_com.json",
+ "baked_in_configs/c_bigcache_googleapis_com.json",
+ "baked_in_configs/c_doc-0-0-sj_sj_googleusercontent_com.json",
+ "baked_in_configs/c_docs_google_com.json",
+ "baked_in_configs/c_drive_google_com.json",
+ "baked_in_configs/c_googlesyndication_com.json",
+ "baked_in_configs/c_pack_google_com.json",
+ "baked_in_configs/c_play_google_com.json",
+ "baked_in_configs/c_youtube_com.json",
+ "baked_in_configs/clients2_google_com.json",
+ "baked_in_configs/docs_google_com.json",
+ "baked_in_configs/google-analytics_com.json",
+ "baked_in_configs/googlevideo_com.json",
+ "baked_in_configs/gvt1_com.json",
+ "baked_in_configs/gvt2_com.json",
+ "baked_in_configs/ssl_gstatic_com.json",
+ "baked_in_configs/www_google_com.json",
+ ]
+
output_file = "$target_gen_dir/baked_in_configs.cc"
outputs = [
output_file,
@@ -31,7 +33,7 @@ action("bake_in_configs") {
# The JSON file list is too long for the command line on Windows, so put
# them in a response file.
- response_file_contents = rebase_path(baked_in_configs, root_build_dir)
+ response_file_contents = rebase_path(inputs, root_build_dir)
args = [
"--file-list",
"{{response_file_name}}",
« no previous file with comments | « components/domain_reliability.gypi ('k') | components/domain_reliability/baked_in_configs.gypi » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698