Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(939)

Unified Diff: src/parsing/parser.h

Issue 2306413002: Fully deserialize the scope chain after parsing, not before (Closed)
Patch Set: updates Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/parsing/parser.h
diff --git a/src/parsing/parser.h b/src/parsing/parser.h
index d01931d87741f5eacebbe776fc94d284bf580bd1..1784a3561b8ededc29770cdd507982de2c966126 100644
--- a/src/parsing/parser.h
+++ b/src/parsing/parser.h
@@ -182,8 +182,7 @@ class Parser : public ParserBase<Parser> {
bool Parse(ParseInfo* info);
void ParseOnBackground(ParseInfo* info);
- void DeserializeScopeChain(ParseInfo* info, Handle<Context> context,
- Scope::DeserializationMode deserialization_mode);
+ void InspectScopeChain(ParseInfo* info, Handle<ScopeInfo> scope_info);
marja 2016/09/12 07:50:33 Pls add a comment explaining what this does.
jochen (gone - plz use gerrit) 2016/09/12 08:18:18 done
// Handle errors detected during parsing, move statistics to Isolate,
// internalize strings (move them to the heap).
@@ -448,10 +447,6 @@ class Parser : public ParserBase<Parser> {
// from a non-simple parameter list.
void InsertShadowingVarBindingInitializers(Block* block);
- // Implement sloppy block-scoped functions, ES2015 Annex B 3.3
- void InsertSloppyBlockFunctionVarBindings(DeclarationScope* scope,
- bool* ok);
-
VariableProxy* NewUnresolved(const AstRawString* name, int begin_pos,
int end_pos = kNoSourcePosition,
VariableKind kind = NORMAL_VARIABLE);
@@ -1040,12 +1035,9 @@ class Parser : public ParserBase<Parser> {
Scanner scanner_;
PreParser* reusable_preparser_;
- Scope* original_scope_; // for ES5 function declarations in sloppy eval
-
friend class ParserTarget;
friend class ParserTargetScope;
ParserTarget* target_stack_; // for break, continue statements
-
ScriptCompiler::CompileOptions compile_options_;
ParseData* cached_parse_data_;

Powered by Google App Engine
This is Rietveld 408576698