Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(439)

Unified Diff: src/compiler-dispatcher/compiler-dispatcher-job.cc

Issue 2306413002: Fully deserialize the scope chain after parsing, not before (Closed)
Patch Set: updates Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/compiler-dispatcher/compiler-dispatcher-job.cc
diff --git a/src/compiler-dispatcher/compiler-dispatcher-job.cc b/src/compiler-dispatcher/compiler-dispatcher-job.cc
index d6b570449f64e92541ed61ec6b3982dea9758479..237ccbc1b064b5cf64deb13fb016185a798a738f 100644
--- a/src/compiler-dispatcher/compiler-dispatcher-job.cc
+++ b/src/compiler-dispatcher/compiler-dispatcher-job.cc
@@ -83,9 +83,11 @@ void CompilerDispatcherJob::PrepareToParseOnMainThread() {
parse_info_->set_language_mode(shared->language_mode());
parser_.reset(new Parser(parse_info_.get()));
- parser_->DeserializeScopeChain(
- parse_info_.get(), handle(function_->context(), isolate_),
- Scope::DeserializationMode::kDeserializeOffHeap);
+ parser_->InspectScopeChain(
+ parse_info_.get(),
+ function_->context()->IsNativeContext()
+ ? Handle<ScopeInfo>::null()
+ : handle(function_->context()->scope_info(), isolate_));
Handle<String> name(String::cast(shared->name()));
parse_info_->set_function_name(

Powered by Google App Engine
This is Rietveld 408576698