Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(139)

Unified Diff: src/ast/scopes.h

Issue 2306413002: Fully deserialize the scope chain after parsing, not before (Closed)
Patch Set: cleanup Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/ast/ast.h ('k') | src/ast/scopes.cc » ('j') | src/ast/scopes.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/ast/scopes.h
diff --git a/src/ast/scopes.h b/src/ast/scopes.h
index 1bec87f6636aeb1857d0217350b14c77adf907b9..8e9f9f2b36151272af3880b7b2bc6da0961616df 100644
--- a/src/ast/scopes.h
+++ b/src/ast/scopes.h
@@ -98,7 +98,7 @@ class Scope: public ZoneObject {
int top_decl_;
};
- enum class DeserializationMode { kDeserializeOffHeap, kKeepScopeInfo };
+ enum class DeserializationMode { kIncludingVariables, kScopesOnly };
static Scope* DeserializeScopeChain(Isolate* isolate, Zone* zone,
Context* context,
@@ -575,9 +575,6 @@ class Scope: public ZoneObject {
void SetDefaults();
- void DeserializeScopeInfo(Isolate* isolate,
- AstValueFactory* ast_value_factory);
-
friend class DeclarationScope;
};
@@ -747,7 +744,7 @@ class DeclarationScope : public Scope {
// Go through sloppy_block_function_map_ and hoist those (into this scope)
// which should be hoisted.
- void HoistSloppyBlockFunctions(AstNodeFactory* factory, bool* ok);
+ void HoistSloppyBlockFunctions(AstNodeFactory* factory);
SloppyBlockFunctionMap* sloppy_block_function_map() {
return &sloppy_block_function_map_;
« no previous file with comments | « src/ast/ast.h ('k') | src/ast/scopes.cc » ('j') | src/ast/scopes.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698