Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(290)

Unified Diff: test/cctest/test-parsing.cc

Issue 2306413002: Fully deserialize the scope chain after parsing, not before (Closed)
Patch Set: updates Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: test/cctest/test-parsing.cc
diff --git a/test/cctest/test-parsing.cc b/test/cctest/test-parsing.cc
index 383d372770b9314e491038544fdaa1b963bfb735..7d38aab1f3db84d0a467e128259c8a24554ee359 100644
--- a/test/cctest/test-parsing.cc
+++ b/test/cctest/test-parsing.cc
@@ -3403,9 +3403,8 @@ TEST(SerializationOfMaybeAssignmentFlag) {
CHECK(str->IsInternalizedString());
i::DeclarationScope* script_scope =
new (&zone) i::DeclarationScope(&zone, &avf);
- i::Scope* s = i::Scope::DeserializeScopeChain(
- isolate, &zone, context, script_scope, &avf,
- i::Scope::DeserializationMode::kKeepScopeInfo);
+ i::Scope* s = i::Scope::DeserializeScopeChainForTesting(
+ isolate, &zone, context, script_scope, &avf);
CHECK(s != script_scope);
CHECK(name != NULL);
@@ -3451,9 +3450,8 @@ TEST(IfArgumentsArrayAccessedThenParametersMaybeAssigned) {
i::DeclarationScope* script_scope =
new (&zone) i::DeclarationScope(&zone, &avf);
- i::Scope* s = i::Scope::DeserializeScopeChain(
- isolate, &zone, context, script_scope, &avf,
- i::Scope::DeserializationMode::kKeepScopeInfo);
+ i::Scope* s = i::Scope::DeserializeScopeChainForTesting(
+ isolate, &zone, context, script_scope, &avf);
CHECK(s != script_scope);
const i::AstRawString* name_x = avf.GetOneByteString("x");

Powered by Google App Engine
This is Rietveld 408576698