Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(333)

Unified Diff: src/background-parsing-task.cc

Issue 2306413002: Fully deserialize the scope chain after parsing, not before (Closed)
Patch Set: updates Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/background-parsing-task.cc
diff --git a/src/background-parsing-task.cc b/src/background-parsing-task.cc
index fc5cbb45a68197d4e40060afd22d5bf8469fa952..5ae55cdbd2d16ef1106eeeba2f8b32946e4d5769 100644
--- a/src/background-parsing-task.cc
+++ b/src/background-parsing-task.cc
@@ -50,9 +50,8 @@ BackgroundParsingTask::BackgroundParsingTask(
// Parser needs to stay alive for finalizing the parsing on the main
// thread.
source_->parser.reset(new Parser(source_->info.get()));
- source_->parser->DeserializeScopeChain(
- source_->info.get(), Handle<Context>::null(),
- Scope::DeserializationMode::kDeserializeOffHeap);
+ source_->parser->InspectScopeChain(source_->info.get(),
+ MaybeHandle<ScopeInfo>());
}

Powered by Google App Engine
This is Rietveld 408576698