Use V8_FINAL and V8_OVERRIDE in various places, fixing bugs revealed by them.

Use V8_FINAL and V8_OVERRIDE in various places, fixing bugs revealed by them.

- Use V8_FINAL and V8_OVERRIDE in objects.
- Use V8_FINAL and V8_OVERRIDE in Ast classes.
- Use V8_FINAL and V8_OVERRIDE in Lithium mips backend.
- Use V8_FINAL and V8_OVERRIDE in Lithium arm backend.
- Use V8_FINAL and V8_OVERRIDE in Lithium x64 backend.
- Use V8_FINAL and V8_OVERRIDE in Lithium ia32 backend.
- Use V8_FINAL and V8_OVERRIDE in Lithium classes.
- Use V8_FINAL and V8_OVERRIDE in Hydrogen classes.

R=dslomov@chromium.org

Committed: https://code.google.com/p/v8/source/detail?r=16232

[Benedikt Meurer, 2013-08-19 14:51:02]

PTAL

[Dmitry Lomov (no reviews), 2013-08-19 16:20:22]

LGTM!
I think we should make the use of FINAL and OVERRIDE mandatory in all new code
(except additions to public API)

[Benedikt Meurer, 2013-08-19 18:20:01]

On 2013/08/19 16:20:22, Dmitry Lomov (chromium) wrote:
> LGTM!
> I think we should make the use of FINAL and OVERRIDE mandatory in all new code
> (except additions to public API)

Hm, looking through the code again, we should probably use V8_FINAL and
V8_OVERRIDE to avoid collisions with other people's #define's. We already had to
redefine one FINAL enum in our own code because of this. Opinions?

[Benedikt Meurer, 2013-08-20 07:26:26]

On 2013/08/19 18:20:01, Benedikt Meurer wrote:
> On 2013/08/19 16:20:22, Dmitry Lomov (chromium) wrote:
> > LGTM!
> > I think we should make the use of FINAL and OVERRIDE mandatory in all new
code
> > (except additions to public API)
> 
> Hm, looking through the code again, we should probably use V8_FINAL and
> V8_OVERRIDE to avoid collisions with other people's #define's. We already had
to
> redefine one FINAL enum in our own code because of this. Opinions?

Better safe than sorry, properly prefixed with V8_ now.

[Benedikt Meurer, 2013-08-20 07:27:31]

Committed patchset #2 manually as r16232.