net/proxy/proxy_script_fetcher_impl.cc - Issue 23064011: Consolidate scheme checks into an easy GURL method

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/proxy/proxy_script_fetcher_impl.cc

Issue 23064011: Consolidate scheme checks into an easy GURL method (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 7 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: net/proxy/proxy_script_fetcher_impl.cc

diff --git a/net/proxy/proxy_script_fetcher_impl.cc b/net/proxy/proxy_script_fetcher_impl.cc

index 2bf9e6677921e526d0f731da8e0412b6a4ee5a4d..f300fb7b4cc74e5932f838eebba462e8d568419f 100644

--- a/net/proxy/proxy_script_fetcher_impl.cc

+++ b/net/proxy/proxy_script_fetcher_impl.cc

@@ -211,7 +211,7 @@ void ProxyScriptFetcherImpl::OnResponseStarted(URLRequest* request) {

}

// Require HTTP responses to have a success status code.

- if (request->url().SchemeIs("http") || request->url().SchemeIs("https")) {

+ if (request->url().SchemeIsHttp()) {

// NOTE about status codes: We are like Firefox 3 in this respect.

// {IE 7, Safari 3, Opera 9.5} do not care about the status code.

if (request->GetResponseCode() != 200) {