content/browser/download/file_metadata_mac.mm - Issue 23064011: Consolidate scheme checks into an easy GURL method

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/download/file_metadata_mac.mm

Issue 23064011: Consolidate scheme checks into an easy GURL method (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 7 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/download/file_metadata_mac.mm

diff --git a/content/browser/download/file_metadata_mac.mm b/content/browser/download/file_metadata_mac.mm

index fc0556e0a3b4b6650221f45878fbef461b160e76..18eb74cbbb69eb4270e27a2b3e83f95ce0fee8b1 100644

--- a/content/browser/download/file_metadata_mac.mm

+++ b/content/browser/download/file_metadata_mac.mm

@@ -132,7 +132,7 @@ void AddQuarantineMetadataToFile(const base::FilePath& file, const GURL& source,

// need to set the values that the OS can't infer.

if (![quarantine_properties valueForKey:(NSString*)kLSQuarantineTypeKey]) {

- CFStringRef type = (source.SchemeIs("http") || source.SchemeIs("https"))

+ CFStringRef type = source.SchemeIsHttp()

? kLSQuarantineTypeWebDownload

: kLSQuarantineTypeOtherDownload;

[quarantine_properties setValue:(NSString*)type