Issue 23064003: Expect and check for dependency change during code generation.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 23064003: Expect and check for dependency change during code generation. (Closed)

Created:
7 years, 4 months ago by Yang

Modified:
7 years, 4 months ago

Reviewers:
Jakob Kummerow

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Expect and check for dependency change during code generation. R=jkummerow@chromium.org BUG=

Patch Set 1 #

Created: 7 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -1 line)			Patch
	M	src/compiler.cc	View		2 chunks	+5 lines, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Yang

On 2013/08/13 16:20:33, Yang wrote: arm.debug tests are triggering the assertion that I removed. Instead, ...

7 years, 4 months ago (2013-08-13 16:21:12 UTC) #2

Jakob Kummerow

LGTM. Can we have a platform-independent repro case? A follow-up CL is fine.

7 years, 4 months ago (2013-08-13 16:22:23 UTC) #3

Yang

7 years, 4 months ago (2013-08-13 16:58:32 UTC) #4

On 2013/08/13 16:22:23, Jakob wrote:
> LGTM.
> 
> Can we have a platform-independent repro case? A follow-up CL is fine.

Fixed it in https://codereview.chromium.org/23036004/

Expand Messages | Collapse Messages