net/cookies/canonical_cookie.cc - Issue 2306393002: Loosen strict 'Secure' checks for non-overlapping paths.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/cookies/canonical_cookie.cc

Issue 2306393002: Loosen strict 'Secure' checks for non-overlapping paths. (Closed)

Patch Set: oops Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: net/cookies/canonical_cookie.cc

diff --git a/net/cookies/canonical_cookie.cc b/net/cookies/canonical_cookie.cc

index b8dd63b6227c67ca0846bba47f5a15b376a1961f..bbabbb771a480977bb53e665d4a2824a1e33dc00 100644

--- a/net/cookies/canonical_cookie.cc

+++ b/net/cookies/canonical_cookie.cc

@@ -305,7 +305,8 @@ std::unique_ptr<CanonicalCookie> CanonicalCookie::Create(

bool CanonicalCookie::IsEquivalentForSecureCookieMatching(

const CanonicalCookie& ecc) const {

return (name_ == ecc.Name() && (ecc.IsDomainMatch(DomainWithoutDot()) ||

- IsDomainMatch(ecc.DomainWithoutDot())));

+ IsDomainMatch(ecc.DomainWithoutDot())) &&

+ ecc.IsOnPath(Path()));

}

bool CanonicalCookie::IsOnPath(const std::string& url_path) const {

« no previous file with comments | « net/cookies/canonical_cookie.h ('k') | net/cookies/canonical_cookie_unittest.cc » ('j') | no next file with comments »