Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(328)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2306383004: [Chromecast][GN] Cleanup gn check errors (Closed)

Created:
4 years, 3 months ago by mbjorge
Modified:
4 years, 3 months ago
Reviewers:
slan
CC:
alokp+watch_chromium.org, chromium-reviews, feature-media-reviews_chromium.org, halliwell+watch_chromium.org, lcwu+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Chromecast][GN] Cleanup gn check errors BUG= internal b/31275665 TEST= gn check all the platforms Committed: https://crrev.com/7212ed1dbe75a59b2d8694b483554b3d3098eca6 Cr-Commit-Position: refs/heads/master@{#417605}

Patch Set 1 #

Patch Set 2 : Rebase on latest master #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M chromecast/common/media/BUILD.gn View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 13 (5 generated)
mbjorge
4 years, 3 months ago (2016-09-06 21:04:36 UTC) #2
mbjorge
4 years, 3 months ago (2016-09-08 22:33:14 UTC) #3
slan
lgtm
4 years, 3 months ago (2016-09-09 00:54:39 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2306383004/20001
4 years, 3 months ago (2016-09-09 00:55:04 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/290185)
4 years, 3 months ago (2016-09-09 01:53:44 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2306383004/20001
4 years, 3 months ago (2016-09-09 15:53:24 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 3 months ago (2016-09-09 16:47:46 UTC) #11
commit-bot: I haz the power
4 years, 3 months ago (2016-09-09 16:50:36 UTC) #13
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/7212ed1dbe75a59b2d8694b483554b3d3098eca6
Cr-Commit-Position: refs/heads/master@{#417605}

Powered by Google App Engine
This is Rietveld 408576698