Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(420)

Issue 2306383002: Blacklist GDEF tables for Padauk fonts (Closed)

Created:
4 years, 3 months ago by drott
Modified:
4 years, 3 months ago
Reviewers:
kojii, eae, behdad
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Blacklist GDEF tables for Padauk fonts The Padauk fonts have broken GDEF tables that define a set of Latin characters as marks, which leads to collapsed advances. More details in https://github.com/behdad/harfbuzz/issues/305 BUG=637464 R=behdad,eae,kojii Committed: https://crrev.com/17dc0df0ddb82ed1a2733316139856f67317b51b Cr-Commit-Position: refs/heads/master@{#416533}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -0 lines) Patch
M third_party/harfbuzz-ng/README.chromium View 1 chunk +3 lines, -0 lines 0 comments Download
M third_party/harfbuzz-ng/src/hb-ot-layout.cc View 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
drott
4 years, 3 months ago (2016-09-05 08:14:32 UTC) #3
behdad
lgtm Can you please send this upstream as well? And I know, a HarfBuzz release ...
4 years, 3 months ago (2016-09-05 08:17:29 UTC) #4
drott
On 2016/09/05 at 08:17:29, behdad wrote: > lgtm > > Can you please send this ...
4 years, 3 months ago (2016-09-05 08:19:04 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2306383002/1
4 years, 3 months ago (2016-09-05 11:57:06 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-05 12:00:35 UTC) #10
commit-bot: I haz the power
4 years, 3 months ago (2016-09-05 12:02:45 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/17dc0df0ddb82ed1a2733316139856f67317b51b
Cr-Commit-Position: refs/heads/master@{#416533}

Powered by Google App Engine
This is Rietveld 408576698