Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Issue 230633002: Revert "Fix None target type with Ninja build." (Closed)

Created:
6 years, 8 months ago by Torne
Modified:
6 years, 8 months ago
Reviewers:
etienneb, scottmg
CC:
gyp-developer_googlegroups.com
Visibility:
Public.

Description

Revert "Fix None target type with Ninja build." This reverts r1883, which seems to be causing gyp-win32 bot failures on test\ninja\solibs_avoid_relinking\gyptest-solibs-avoid-relinking.py and test\win\gyptest-link-restat-importlib.py. BUG= TBR=etienneb@chromium.org,scottmg@chromium.org Committed: https://code.google.com/p/gyp/source/detail?r=1892

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -41 lines) Patch
M pylib/gyp/generator/ninja.py View 1 chunk +0 lines, -2 lines 0 comments Download
D test/ninja/none-rules/gyptest-none-rules.py View 1 chunk +0 lines, -26 lines 0 comments Download
D test/ninja/none-rules/none-rules.gyp View 1 chunk +0 lines, -13 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Torne
6 years, 8 months ago (2014-04-09 11:28:19 UTC) #1
Torne
6 years, 8 months ago (2014-04-09 11:30:38 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 manually as r1892 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698