Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(433)

Issue 2306273002: Subzero: Fix target attribute when SZTARGET is defined. (Closed)

Created:
4 years, 3 months ago by Jim Stichnoth
Modified:
4 years, 3 months ago
Reviewers:
Eric Holk, Karl, capn, John
CC:
native-client-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Subzero: Fix target attribute when SZTARGET is defined. Adds the right macro voodoo so that when Subzero is built for a single target, e.g.: $ make -f Makefile.standalone SZTARGET=ARM32 we get output like this: $ ./pnacl-sz --build-atts target_ARM32 rather than this: $ ./pnacl-sz --build-atts target_SZTARGET BUG= none R=eholk@chromium.org Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a=commit;h=84ea9a70bc14ec528d8d377462317fd46660f3de

Patch Set 1 #

Patch Set 2 : Use string concatenation. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -3 lines) Patch
M src/IceCompileServer.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M src/IceDefs.h View 1 chunk +3 lines, -0 lines 0 comments Download
M src/IceRevision.cpp View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 7 (4 generated)
Jim Stichnoth
4 years, 3 months ago (2016-09-04 15:10:03 UTC) #4
Eric Holk
lgtm
4 years, 3 months ago (2016-09-07 20:13:48 UTC) #5
Jim Stichnoth
4 years, 3 months ago (2016-09-09 16:33:10 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
84ea9a70bc14ec528d8d377462317fd46660f3de (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698